From: Bard liao <yung-chuan.liao@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>, alsa-devel@alsa-project.org
Cc: Sanyog Kale <sanyog.r.kale@intel.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v2 0/9] soundwire: use FIELD_{GET|PREP} in subsystem
Date: Fri, 4 Sep 2020 15:46:15 +0800 [thread overview]
Message-ID: <169e2a94-37db-a9c0-748f-99af46aef3e5@linux.intel.com> (raw)
In-Reply-To: <20200903114504.1202143-1-vkoul@kernel.org>
On 9/3/2020 7:44 PM, Vinod Koul wrote:
> Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local
> SDW_REG_SHIFT(). This makes code IMO look much neater
>
> Tested this on db845c board
>
> Changes in v2:
> - fold in fixes provided by Bard and Pierre
> - Use GENMAS_ULL for addr
> - rebase to next and fold in new intel change
>
> Vinod Koul (9):
> soundwire: define and use addr bit masks
> soundwire: bus: use FIELD_GET()
> soundwire: slave: use SDW_DISCO_LINK_ID()
> soundwire: stream: use FIELD_{GET|PREP}
> soundwire: qcom : use FIELD_{GET|PREP}
> soundwire: cadence: use FIELD_{GET|PREP}
> soundwire: intel: use FIELD_{GET|PREP}
> soundwire: intel_init: use FIELD_{GET|PREP}
> soundwire: remove SDW_REG_SHIFT()
>
> drivers/soundwire/bus.c | 6 +--
> drivers/soundwire/cadence_master.c | 61 +++++++++++--------------
> drivers/soundwire/intel.c | 52 ++++++++-------------
> drivers/soundwire/intel_init.c | 2 +-
> drivers/soundwire/qcom.c | 22 +++------
> drivers/soundwire/slave.c | 2 +-
> drivers/soundwire/stream.c | 13 ++----
> include/linux/soundwire/sdw.h | 21 ++++++---
> include/linux/soundwire/sdw_registers.h | 7 ---
> 9 files changed, 75 insertions(+), 111 deletions(-)
Tested it on Intel platforms.
Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com>
next prev parent reply other threads:[~2020-09-04 7:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:44 [PATCH v2 0/9] soundwire: use FIELD_{GET|PREP} in subsystem Vinod Koul
2020-09-03 11:44 ` [PATCH v2 1/9] soundwire: define and use addr bit masks Vinod Koul
2020-09-03 11:44 ` [PATCH v2 2/9] soundwire: bus: use FIELD_GET() Vinod Koul
2020-09-03 11:44 ` [PATCH v2 3/9] soundwire: slave: use SDW_DISCO_LINK_ID() Vinod Koul
2020-09-03 11:44 ` [PATCH v2 4/9] soundwire: stream: use FIELD_{GET|PREP} Vinod Koul
2020-09-03 11:45 ` [PATCH v2 5/9] soundwire: qcom : " Vinod Koul
2020-09-03 11:45 ` [PATCH v2 6/9] soundwire: cadence: " Vinod Koul
2020-09-03 11:45 ` [PATCH v2 7/9] soundwire: intel: " Vinod Koul
2020-09-03 11:45 ` [PATCH v2 8/9] soundwire: intel_init: " Vinod Koul
2020-09-03 11:45 ` [PATCH v2 9/9] soundwire: remove SDW_REG_SHIFT() Vinod Koul
2020-09-04 7:46 ` Bard liao [this message]
2020-09-04 9:18 ` [PATCH v2 0/9] soundwire: use FIELD_{GET|PREP} in subsystem Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169e2a94-37db-a9c0-748f-99af46aef3e5@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox