From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B432C25B7E for ; Fri, 31 May 2024 12:49:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0628683B; Fri, 31 May 2024 14:48:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0628683B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1717159749; bh=RpjgYwPDyJuqrExpz1nNP6Ko9Qg4oE1su/7aCIq+LAM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aKMwihJlPB+A42OqmmBJDAWG/HSDRxVnPek+SKZodZ1UgBr9lRoAmQCfVIubGj1vb sVtwWS41fXMSfISCdvbHQp6BqDAE/+pGIqcoVEiHTyNhqQo5AnvdPOV7U2a7ey1C9C FaOBqkMNklKQPStKl7oig2I/bHED94O5RfCGEI2o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 61EBAF8047C; Fri, 31 May 2024 14:48:29 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 09087F805D8; Fri, 31 May 2024 14:48:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD3AAF8051D; Fri, 31 May 2024 14:48:25 +0200 (CEST) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 32365F80589 for ; Fri, 31 May 2024 14:48:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 32365F80589 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.a=rsa-sha256 header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=CME5Ful2 Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 1F9649C096E; Fri, 31 May 2024 08:48:17 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id wsrHJO9_bBGT; Fri, 31 May 2024 08:48:15 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id B31369C2CD8; Fri, 31 May 2024 08:48:15 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com B31369C2CD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1717159695; bh=XHYg/xXbggBW6T/eEAZpR4M9NzidJhaQVBYe6V+5Uwo=; h=Date:From:To:Message-ID:MIME-Version; b=CME5Ful22NGYQX5X3G/QGYkgnwUNX4QmgtRMXjjWtkoudDR5OH9Vn2oMnBk9H7Lx+ oBqbJM2GPGCWTnBBVwJvtK3H9XEsrgIIro0fnNxSivQPKzby4UKlAiCdzBQmRB3i2X r+l6CIrcJ62QWiIDmyt82kiWN2SKbIlE+lRWeXMD73TBcyyBgostjPISQWIyEJxoRY 8pZTcDY4/DNYag52VbveIAaUDKmCLQVmfHsxJqLnTIIQFIwm9NLq1BSVzsItkwMaBE diSMZ4X/F4wMXc0N05X4P4GoyXrlIV5lwvv1pVNGN3nT1XIcV4TjSZQYX9Ua1MU00J kkiNgxA9AeNew== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id 0-nDvHVWvAtj; Fri, 31 May 2024 08:48:15 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 7FDF39C096E; Fri, 31 May 2024 08:48:15 -0400 (EDT) Date: Fri, 31 May 2024 08:48:15 -0400 (EDT) From: Elinor Montmasson To: Rob Herring Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , shengjiu wang , Xiubo Lee , Fabio Estevam , Nicolin Chen , Jaroslav Kysela , Takashi Iwai , linux-sound , devicetree , linux-kernel , alsa-devel , linuxppc-dev Message-ID: <1712008549.701259.1717159695483.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20240520183148.GA1250699-robh@kernel.org> References: <20240515135411.343333-1-elinor.montmasson@savoirfairelinux.com> <20240515135411.343333-10-elinor.montmasson@savoirfairelinux.com> <20240520183148.GA1250699-robh@kernel.org> Subject: Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec Thread-Index: 9W7FNkO/DHfWsLN9ZmR/Fd4sK0HmGw== Message-ID-Hash: GW3NFGFOXD47LDE2EOVWC3NNUKMRP2FH X-Message-ID-Hash: GW3NFGFOXD47LDE2EOVWC3NNUKMRP2FH X-MailFrom: elinor.montmasson@savoirfairelinux.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "Rob Herring" Sent: Monday, 20 May, 2024 20:31:48 > On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: >> Add documentation about new dts bindings following new support >> for compatible "fsl,imx-audio-generic". >> >> Some CPU DAI don't require a real audio codec. The new compatible >> "fsl,imx-audio-generic" allows using the driver with codec drivers >> SPDIF DIT and SPDIF DIR as dummy codecs. >> It also allows using not pre-configured audio codecs which >> don't require specific control through a codec driver. >> >> The new dts properties give the possibility to set some parameters >> about the CPU DAI usually set through the codec configuration. >> >> Signed-off-by: Elinor Montmasson >> --- >> .../bindings/sound/fsl-asoc-card.yaml | 96 ++++++++++++++++++- >> 1 file changed, 92 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml >> b/Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml >> index 9922664d5ccc..332d8bf96e06 100644 >> --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml >> +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml >> @@ -23,6 +23,16 @@ description: >> and PCM DAI formats. However, it'll be also possible to support those non >> AC'97/I2S/PCM type sound cards, such as S/PDIF audio and HDMI audio, as >> long as the driver has been properly upgraded. >> + To use CPU DAIs that do not require a codec such as an S/PDIF controller, >> + or to use a DAI to output or capture raw I2S/TDM data, you can >> + use the compatible "fsl,imx-audio-generic". >> + >> +definitions: >> + imx-audio-generic-dependency: >> + properties: >> + compatible: >> + contains: >> + const: fsl,imx-audio-generic >> >> maintainers: >> - Shengjiu Wang >> @@ -81,6 +91,7 @@ properties: >> - fsl,imx-audio-wm8960 >> - fsl,imx-audio-wm8962 >> - fsl,imx-audio-wm8958 >> + - fsl,imx-audio-generic >> >> model: >> $ref: /schemas/types.yaml#/definitions/string >> @@ -93,8 +104,14 @@ properties: >> need to add ASRC support via DPCM. >> >> audio-codec: >> - $ref: /schemas/types.yaml#/definitions/phandle >> - description: The phandle of an audio codec >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + The phandle of an audio codec. >> + If using the "fsl,imx-audio-generic" compatible, give instead a pair of >> + phandles with the spdif_transmitter first (driver SPDIF DIT) and the >> + spdif_receiver second (driver SPDIF DIR). > > minItems: 1 > maxItems: 2 > >> + items: >> + maxItems: 1 >> >> audio-cpu: >> $ref: /schemas/types.yaml#/definitions/phandle >> @@ -150,8 +167,8 @@ properties: >> description: dai-link uses bit clock inversion. >> >> mclk-id: >> - $ref: /schemas/types.yaml#/definitions/uint32 >> - description: main clock id, specific for each card configuration. >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: Main clock id for each codec, specific for each card >> configuration. > > minItems: 1 > maxItems: 2 >> >> mux-int-port: >> $ref: /schemas/types.yaml#/definitions/uint32 >> @@ -167,10 +184,68 @@ properties: >> $ref: /schemas/types.yaml#/definitions/phandle >> description: The phandle of an CPU DAI controller >> >> + # Properties relevant only with "fsl,imx-audio-generic" compatible >> + dai-tdm-slot-width: >> + description: See tdm-slot.txt. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + >> + dai-tdm-slot-num: >> + description: See tdm-slot.txt. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + >> + clocks: >> + description: | >> + The CPU DAI system clock, used to retrieve >> + the CPU DAI system clock frequency with the generic codec. >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: cpu_sysclk >> + >> + cpu-system-clock-direction-out: >> + description: | >> + Specifies cpu system clock direction as 'out' on initialization. >> + If not set, direction is 'in'. >> + $ref: /schemas/types.yaml#/definitions/flag >> + >> +dependencies: >> + dai-tdm-slot-width: >> + $ref: "#/definitions/imx-audio-generic-dependency" >> + dai-tdm-slot-num: >> + $ref: "#/definitions/imx-audio-generic-dependency" >> + clocks: >> + $ref: "#/definitions/imx-audio-generic-dependency" >> + cpu-system-clock-direction-out: >> + $ref: "#/definitions/imx-audio-generic-dependency" > > This works, but is an unusual pattern... > >> + >> required: >> - compatible >> - model >> >> +allOf: >> + - if: >> + $ref: "#/definitions/imx-audio-generic-dependency" >> + then: >> + properties: >> + audio-codec: >> + items: >> + - description: SPDIF DIT phandle >> + - description: SPDIF DIR phandle >> + mclk-id: >> + maxItems: 1 >> + items: >> + minItems: 1 >> + maxItems: 2 >> + else: >> + properties: >> + audio-codec: >> + maxItems: 1 >> + mclk-id: >> + maxItems: 1 >> + items: >> + maxItems: 1 > > > You can handle the dependency like this instead: > > dai-tdm-slot-width: false > dai-tdm-slot-num: false > > > And then you don't need the definitions. > >> + >> unevaluatedProperties: false >> >> examples: >> @@ -195,3 +270,16 @@ examples: >> "AIN2L", "Line In Jack", >> "AIN2R", "Line In Jack"; >> }; >> + >> + - | >> + #include >> + sound-spdif-asrc { >> + compatible = "fsl,imx-audio-generic"; >> + model = "spdif-asrc-audio"; >> + audio-cpu = <&spdif>; >> + audio-asrc = <&easrc>; >> + audio-codec = <&spdifdit>, <&spdifdir>; >> + clocks = <&clk IMX8MN_CLK_SAI5_ROOT>; >> + clock-names = "cpu_sysclk"; >> + cpu-system-clock-direction-out; >> + }; >> -- >> 2.34.1 Ok, thank you for the review, I'll make these modifications in v5.