From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Morimoto <kuninori.morimoto.gx@renesas.com>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine
Date: Tue, 22 Jul 2014 15:15:27 +0200 [thread overview]
Message-ID: <1821348.E9ac8e01qX@avalon> (raw)
In-Reply-To: <87sim0ece5.wl%kuninori.morimoto.gx@gmail.com>
Hi Morimoto-san,
Thank you for the patch.
On Wednesday 16 July 2014 23:18:44 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Renesas new DMAEngine driver requests src/dst_addr_width
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> >> Laurent
>
> Could you please check and give your Ack to this patch?
>
> sound/soc/sh/rcar/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
> index 907d480..c48d999 100644
> --- a/sound/soc/sh/rcar/core.c
> +++ b/sound/soc/sh/rcar/core.c
> @@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct
> rsnd_dma *dma, cfg.direction = is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
> cfg.src_addr = rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
> cfg.dst_addr = rsnd_gen_dma_addr(priv, mod_to, is_play, 0);
> + cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> + cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>
> dev_dbg(dev, "dma : %s %pad -> %pad\n",
> dma_name, &cfg.src_addr, &cfg.dst_addr);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-07-22 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 6:18 [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine Kuninori Morimoto
2014-07-18 12:44 ` Laurent Pinchart
2014-07-21 23:55 ` Kuninori Morimoto
2014-07-22 1:11 ` Laurent Pinchart
2014-07-22 2:34 ` Kuninori Morimoto
2014-07-22 13:16 ` Laurent Pinchart
2014-07-23 0:44 ` Kuninori Morimoto
2014-07-22 13:15 ` Laurent Pinchart [this message]
2014-07-22 22:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1821348.E9ac8e01qX@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).