Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: GitHub pull_request - opened <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: sof-soundwire: fix speaker init include for combined codecs
Date: Mon, 14 Sep 2026 15:17:05 +0200 (CEST)	[thread overview]
Message-ID: <18d53261ecfae100-webhooks-bot@alsa-project.org> (raw)
In-Reply-To: <alsa-project/alsa-ucm-conf/pr/855@alsa-project.org>

alsa-project/alsa-ucm-conf pull request #855 was opened from pgavin:

Since commit cd342774cd02 ("sof-soundwire: cleanups for codecs with multiple functions") the speaker init filter regex is not anchored, so a combined speaker codec string like rt721+rt1320 or rt712+rt1320 also matches the single codec names from MultiCodecRegex. The config then tries to include codecs/rt721+rt1320/init.conf, which does not exist, and the whole UCM configuration fails to load:

  could not open configuration file .../ucm2/codecs/rt721+rt1320/init.conf
  failed to import hw:1 use case configuration -2

PipeWire falls back to a stereo profile on PCM 0 and the internal speakers (PCM 2) are never used.

Guard the regex with "=" like the other multi-codec checks, so only exact codec names with a codecs/<name>/init.conf are included. The combined codecs keep using sof-soundwire/<spk>.conf from HiFi.conf, and the rt721 codec init is still included via the headset codec, as before the cleanup.

Tested on Razer Blade 16 (RZ09-0581) with components:
  cfg-amp:2 mic:dmic cfg-mics:2 iec61937-pcm:7,6,5 hs:rt721 spk:rt721+rt1320

Request URL   : https://github.com/alsa-project/alsa-ucm-conf/pull/855
Patch URL     : https://github.com/alsa-project/alsa-ucm-conf/pull/855.patch
Repository URL: https://github.com/alsa-project/alsa-ucm-conf

           reply	other threads:[~2026-09-14 13:17 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <alsa-project/alsa-ucm-conf/pr/855@alsa-project.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18d53261ecfae100-webhooks-bot@alsa-project.org \
    --to=github@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox