Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: GitHub pull_request - opened <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: pulse: fix negative PA_ERR_NODATA comparison in pulse_delay
Date: Mon, 28 Sep 2026 22:40:19 +0200 (CEST)	[thread overview]
Message-ID: <18d996b1def46700-webhooks-bot@alsa-project.org> (raw)
In-Reply-To: <alsa-project/alsa-plugins/pr/68@alsa-project.org>

alsa-project/alsa-plugins pull request #68 was opened from dirty49374:

When `pa_stream_get_latency()` returns `-PA_ERR_NODATA`, `pulse_delay()` compares it against the positive `PA_ERR_NODATA` constant and returns `-EIO`. This turns temporarily unavailable latency information into an I/O error for ALSA clients.

Compare against `-PA_ERR_NODATA` so this case follows the existing mainloop wait/retry path. Other errors still return `-EIO`.

Validation:
- Built the PulseAudio plugins with `make -C pulse -j4`.
- A local test harness exercising the actual `pulse_delay()` implementation passed success, temporary NODATA/retry, permanent error, retry followed by permanent error, and connection failure cases. The NODATA regression case fails with the original comparison. The harness is not included in this one-line patch.
- In a 20-second local CPAL/ALSA integration probe, injecting `-PA_ERR_NODATA` during capture and playback produced I/O errors with the original plugin; the source-built patched plugin continued with zero reported stream errors.

Request URL   : https://github.com/alsa-project/alsa-plugins/pull/68
Patch URL     : https://github.com/alsa-project/alsa-plugins/pull/68.patch
Repository URL: https://github.com/alsa-project/alsa-plugins

           reply	other threads:[~2026-09-28 20:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <alsa-project/alsa-plugins/pr/68@alsa-project.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18d996b1def46700-webhooks-bot@alsa-project.org \
    --to=github@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox