From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH v3 6/8] ASoC: soc-pcm: call snd_soc_component_open/close() once
Date: Wed, 12 Feb 2020 09:26:02 -0600 [thread overview]
Message-ID: <191001ea-1554-0ba2-4336-8f95f159e65b@linux.intel.com> (raw)
In-Reply-To: <87d0akmwq1.wl-kuninori.morimoto.gx@renesas.com>
On 2/11/20 7:16 PM, Kuninori Morimoto wrote:
>
> Hi Pierre-Louis, Mark
>
>>>> Maybe a red-herring but is there a potential for race conditions here if
>>>> that function is called twice from different places? Don't we need some sort
>>>> of lock for all the new flags introduced here?
>>>
>>> The probe stuff is all going to get pretty upset if it's called from
>>> multiple paths already.
>>
>> Hmm.. indeed we need to consider about it.
>> But I think it can/should/will be incremental patch.
>> Thank you for pointing it.
>
> Is it OK for you ?
> Or, do we need v4 patch ?
I can't prove that the code is broken, this was a question. If there is
a follow-up that looks into potential conflicts that's fine, I can see
the benefits of the series as is so
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thank you Morimoto-san for all this work, much appreciated.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-12 16:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 3:13 [alsa-devel] [PATCH v3 0/7] ASoC: soc-pcm cleanup step2 Kuninori Morimoto
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 1/8] ASoC: soc-pcm: add snd_soc_runtime_action() Kuninori Morimoto
2020-02-11 15:48 ` [alsa-devel] Applied "ASoC: soc-pcm: add snd_soc_runtime_action()" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 2/8] ASoC: soc-pcm: adjustment for DAI member 0 reset Kuninori Morimoto
2020-02-11 15:48 ` [alsa-devel] Applied "ASoC: soc-pcm: adjustment for DAI member 0 reset" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 3/8] ASoC: soc-pcm: add for_each_dapm_widgets() macro Kuninori Morimoto
2020-02-11 15:48 ` [alsa-devel] Applied "ASoC: soc-pcm: add for_each_dapm_widgets() macro" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 4/8] ASoC: soc-pcm: don't use bit-OR'ed error Kuninori Morimoto
2020-02-11 15:48 ` [alsa-devel] Applied "ASoC: soc-pcm: don't use bit-OR'ed error" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 5/8] ASoC: soc-pcm: call snd_soc_dai_startup()/shutdown() once Kuninori Morimoto
2020-02-11 15:48 ` [alsa-devel] Applied "ASoC: soc-pcm: call snd_soc_dai_startup()/shutdown() once" to the asoc tree Mark Brown
2020-03-27 18:16 ` [alsa-devel] [PATCH v3 5/8] ASoC: soc-pcm: call snd_soc_dai_startup()/shutdown() once Amadeusz Sławiński
2020-03-27 18:38 ` Pierre-Louis Bossart
2020-03-30 1:10 ` Kuninori Morimoto
2020-03-30 7:25 ` Amadeusz Sławiński
2020-03-30 11:08 ` Mark Brown
2020-03-30 23:28 ` Kuninori Morimoto
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 6/8] ASoC: soc-pcm: call snd_soc_component_open/close() once Kuninori Morimoto
2020-02-10 14:41 ` Pierre-Louis Bossart
2020-02-11 12:16 ` Mark Brown
2020-02-12 0:32 ` Kuninori Morimoto
2020-02-12 1:16 ` Kuninori Morimoto
2020-02-12 15:26 ` Pierre-Louis Bossart [this message]
2020-02-12 23:57 ` [alsa-devel] Applied "ASoC: soc-pcm: call snd_soc_component_open/close() once" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 7/8] ASoC: soc-pcm: move soc_pcm_close() next to soc_pcm_open() Kuninori Morimoto
2020-02-12 23:57 ` [alsa-devel] Applied "ASoC: soc-pcm: move soc_pcm_close() next to soc_pcm_open()" to the asoc tree Mark Brown
2020-02-10 3:14 ` [alsa-devel] [PATCH v3 8/8] ASoC: soc-pcm: tidyup soc_pcm_open() order Kuninori Morimoto
2020-02-12 23:57 ` [alsa-devel] Applied "ASoC: soc-pcm: tidyup soc_pcm_open() order" to the asoc tree Mark Brown
2020-02-18 19:14 ` [alsa-devel] [PATCH v3 0/7] ASoC: soc-pcm cleanup step2 Dmitry Osipenko
2020-02-19 1:30 ` Kuninori Morimoto
2020-02-19 16:09 ` Pierre-Louis Bossart
2020-02-19 17:01 ` Kai Vehmanen
2020-02-19 17:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191001ea-1554-0ba2-4336-8f95f159e65b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox