From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Filip Brozovic <fbrozovic@gmail.com>
Subject: Re: [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP
Date: Wed, 22 Jul 2015 10:58:57 +0200 [thread overview]
Message-ID: <1979834.BYYY6Fhuui@ws-stein> (raw)
In-Reply-To: <1437535665.17780.1.camel@ingics.com>
On Wednesday 22 July 2015 11:27:45, Axel Lin wrote:
> Currently, below code actually does not update any bit because
> SGTL5000_SMALL_POP is 0.
>
> snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
>
> The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
I can not test this right now, but it seems appropriate.
Acked-By: Alexander Stein <alexander.stein@systec-electronic.com>
> Hi,
> I don't have h/w and datasheet, but the code looks obvious does not make
> sense. Can someone help to confirm and test if this patch?
The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com
Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany
Office: +49 (0) 3765 38600-0
Fax: +49 (0) 3765 38600-4100
Managing Directors:
Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com
Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany
Office: +49 (0) 3765 38600-0
Fax: +49 (0) 3765 38600-4100
Managing Directors:
Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010
next prev parent reply other threads:[~2015-07-22 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 3:27 [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP Axel Lin
2015-07-22 8:58 ` Alexander Stein [this message]
2015-07-22 9:45 ` Axel Lin
2015-07-22 10:55 ` Fabio Estevam
2015-07-22 9:57 ` Applied "ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP" to the asoc tree Mark Brown
2015-07-22 10:15 ` [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP Zeng Zhaoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1979834.BYYY6Fhuui@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=fbrozovic@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox