From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBCFC433E4 for ; Wed, 22 Jul 2020 15:42:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 360EA2065F for ; Wed, 22 Jul 2020 15:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="r3N/EXLY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 360EA2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B6A52950; Wed, 22 Jul 2020 17:41:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B6A52950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595432524; bh=mX7aKZHm06EIHeLQANofJeCJi1MrIvFOWFVOFijSEzQ=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r3N/EXLY+ofiwVzFaNnLvYo1U8GEFKu44dPCeFCxqgLQNrMA/5qWURkPbiWah13OX ki6egHxIEcph6nRqTUetHvLyXhuQphWTgdxjwckYmGdoD+CZv405Ad6ha15BPazdWg NGDvqVrMsgGn+dWSNWBFK5FO//ynnCSZucowQrqw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 55586F802C3; Wed, 22 Jul 2020 17:39:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47D88F80150; Wed, 22 Jul 2020 17:39:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0A0C3F80161 for ; Wed, 22 Jul 2020 17:39:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0A0C3F80161 IronPort-SDR: m5v5sOI/Fm2VGQqqz2AvcPfBXRg1UjpEtbk0DZ7FESLZKUj4BQPvqRN7U6Ck9SWQq1RZuH5nv4 nlkfHvFuob7w== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="129920856" X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="129920856" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 08:39:25 -0700 IronPort-SDR: C2b6oH9BHmaHESFEJSQjOO1ebe0W9GOq0rwBYNyMB/IOzJs5StxBRs5w1vBDVlUaxH7SQzY3BD qF7lrsn0wNUg== X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="272042516" Received: from asinghi-mobl2.amr.corp.intel.com (HELO [10.255.231.54]) ([10.255.231.54]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 08:39:24 -0700 Subject: Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters To: Srinivas Kandagatla , broonie@kernel.org References: <20200721170007.4554-1-srinivas.kandagatla@linaro.org> <20200721170007.4554-3-srinivas.kandagatla@linaro.org> <9bbfebf9-9a70-46e3-1808-413d04aa6b2c@linaro.org> From: Pierre-Louis Bossart Message-ID: <19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com> Date: Wed, 22 Jul 2020 10:36:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9bbfebf9-9a70-46e3-1808-413d04aa6b2c@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, vkoul@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>>    * and the stream properties >>> + * @set_codec_params: Sets the compressed stream codec parameters, >>> Optional >>> + * This can be called in during gapless next track codec change only >>> to set >>> + * codec params >> >> Would it be clearer if this was called set_next_codec_params()? or >> set_next_track_codec_params()? >> >> Having set_params() and set_codec_params() is a bit confusing since >> the semantic difference is not captured in the callback name. > > set_next_track_codec_params seems more sensible as its next track params. > Will change this in next version! maybe set_params() and set_next_track_params() are enough, not sure if the codec reference helps?