From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE0B6CD1288 for ; Mon, 1 Apr 2024 16:32:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5C4F223D4; Mon, 1 Apr 2024 18:31:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5C4F223D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1711989129; bh=X6o+CiRuRbPSoFA1uNV4CraaV9Ro04bAs5btj8iowP0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=vt6n5pqsEVRvJ5gYZW6rcSUremCDbCWG+pH1WrbrzlmIeJtQxkyrCbPRBTfHOsirk SaqxUvXvIUwKHa7cMdA/QNqcB06teLrjvGX/vRfBgMSu80vRq/Zm52BF29tUEpg2qh UoPe9kg02yaXBj/dgzZDIE0WQ6FKNiIp6/OeFqYc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 047DAF805EE; Mon, 1 Apr 2024 18:31:07 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 979ECF805F3; Mon, 1 Apr 2024 18:31:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F0FA2F8055C; Mon, 1 Apr 2024 18:30:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6E544F80236 for ; Mon, 1 Apr 2024 18:30:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6E544F80236 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QIJ38AlZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711989050; x=1743525050; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=X6o+CiRuRbPSoFA1uNV4CraaV9Ro04bAs5btj8iowP0=; b=QIJ38AlZvcUdUOlXTUo710bIu9YN8jFCv5rxNLiFuw0VWK9dXE4tTTbw 6RuPdAckgiBOZwNdfwXuC2zDmX7cCzBoXS6XVNyb3/bjtKKWddWXYHMLe qE4/FdQvfP9dM5fpmZt/fYneomY9tUaO+T+X3EIIYpKKXxkLWtAaaulBA zpL3h0a/psT97MOKwz5RpMwPyhbkYBJ2Rd/zCO+pIDLK9zixvkBrziRvS /fpoBVBFYbkVSo7AJUyWRA4lunHeONzUhymYa08xWiD9tY/jArH9edEPO wz3z5S8/iDocouO1MhMXPSj/ozuI3P+Wqhi22BKaSqrWQoYKNlhOjl+dR g==; X-CSE-ConnectionGUID: hjwm6ltjToiAJse9itLcHw== X-CSE-MsgGUID: f73mKAsoSIeEYrCUsCybdQ== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="10083752" X-IronPort-AV: E=Sophos;i="6.07,172,1708416000"; d="scan'208";a="10083752" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 09:30:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,172,1708416000"; d="scan'208";a="18224587" Received: from anahar-mobl.amr.corp.intel.com (HELO [10.212.2.239]) ([10.212.2.239]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 09:30:43 -0700 Message-ID: <1a42ebbb-1e1f-4ecf-a1ec-7af292f7ff96@linux.intel.com> Date: Mon, 1 Apr 2024 11:22:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/16] ASoC: soc-core: Replace dpcm_playback/capture to playback/capture_only To: Kuninori Morimoto , =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= , Alper Nebi Yasak , AngeloGioacchino Del Regno , Banajit Goswami , Bard Liao , Brent Lu , Cezary Rojewski , Cristian Ciocaltea , Daniel Baluta , Hans de Goede , Jaroslav Kysela , Jerome Brunet , Kai Vehmanen , Kevin Hilman , Liam Girdwood , Linus Walleij , Mark Brown , Maso Huang , Matthias Brugger , Neil Armstrong , Peter Ujfalusi , Ranjani Sridharan , Sascha Hauer , Shawn Guo , Shengjiu Wang , Srinivas Kandagatla , Sylwester Nawrocki , Takashi Iwai , Trevor Wu , Vinod Koul , Xiubo Li , alsa-devel@alsa-project.org, imx@lists.linux.dev, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <87zfuesz8y.wl-kuninori.morimoto.gx@renesas.com> <87msqdudn7.wl-kuninori.morimoto.gx@renesas.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <87msqdudn7.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: OXPGRO4MFPTMCGUHD54QKYSGXSOXAKCS X-Message-ID-Hash: OXPGRO4MFPTMCGUHD54QKYSGXSOXAKCS X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/31/24 19:31, Kuninori Morimoto wrote: > soc_get_playback_capture() is now handling DPCM and normal comprehensively > for playback/capture stream. We can use playback/capture_only flag > instead of using dpcm_playback/capture. This patch replace these. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Amadeusz Sławiński > --- > sound/soc/soc-core.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 3ab6626ad680..b168cf642092 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -2000,25 +2000,7 @@ static void soc_check_tplg_fes(struct snd_soc_card *card) > dai_link->platforms->name = component->name; > > /* convert non BE into BE */ > - if (!dai_link->no_pcm) { > - dai_link->no_pcm = 1; > - > - if (dai_link->dpcm_playback) > - dev_warn(card->dev, > - "invalid configuration, dailink %s has flags no_pcm=0 and dpcm_playback=1\n", > - dai_link->name); > - if (dai_link->dpcm_capture) > - dev_warn(card->dev, > - "invalid configuration, dailink %s has flags no_pcm=0 and dpcm_capture=1\n", > - dai_link->name); > - > - /* convert normal link into DPCM one */ > - if (!(dai_link->dpcm_playback || > - dai_link->dpcm_capture)) { > - dai_link->dpcm_playback = !dai_link->capture_only; > - dai_link->dpcm_capture = !dai_link->playback_only; > - } > - } > + dai_link->no_pcm = 1; > > /* > * override any BE fixups Not following this last change either, the code used to be conditional /* convert non BE into BE */ if (!dai_link->no_pcm) { dai_link->no_pcm = 1; and not it's unconditional dai_link->no_pcm = 1; It's not clear to me how this is related to the dpcm_playback/dpcm_capture removal.