Re: Reforming s3c2443 ac97 driver

[jassi brar <jassisinghbrar@gmail.com>]

On Thu, Jan 21, 2010 at 7:37 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Thu, 2010-01-21 at 15:58 +0900, jassi brar wrote:
>> The s3c2443-ac97.c is used by SMDK2443 and LN2440SBC machines. My new
>> driver is at least as good as old one for SMDK2443(both detect
>> controller fine but none produce any sound..
>> might be some h/w issue on the only board I have got).
>
> It does sound like the AC97 link is up and running. What codec is used
> here ?
Yes, link is fine. Irqs happen too and no xruns. Just I can't hear anything.

>> I have no access to LN2440SBC but there is no reason for it to
>> complain.
>> Besides, the new AC97 controller driver(plus a machine driver for
>> SMDKs with WM9713 attached to AC97 port) has been tested on all
>> SoCs that I could get my hands on(6410, C100, C110 and V210).
>>
> It would be good if you could also confirm that AC97 warm reset, AC97
> cold reset and VRA (rates other than 48kHz) all work with the new
> driver. Fwiw, it does sound like AC97 warm reset works since the WM9713
> probes (it's default state requires warm reset to wake up the link).
New driver does cold and warm reset only in callback hooks.
Link is enabled in ac97 read/write-reg when the status is not ACTIVE.
VRA works too.