From: jassi brar <jassisinghbrar@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: kyungmin.park@samsung.com, alsa-devel@alsa-project.org,
Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: Separate dma driver for cpu_dais
Date: Thu, 18 Feb 2010 11:14:57 +0900 [thread overview]
Message-ID: <1b68c6791002171814k28fccf9emcbcf17c54c445a4f@mail.gmail.com> (raw)
In-Reply-To: <20100217131421.GB11510@rakim.wolfsonmicro.main>
On Wed, Feb 17, 2010 at 10:14 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Feb 17, 2010 at 09:15:56PM +0900, jassi brar wrote:
>> On Wed, Feb 17, 2010 at 7:52 PM, Mark Brown
>
>> > What modifications are you looking for here? ASoC doesn't make any
>> > effort to avoid reuse of DAIs in multiple links - it doesn't actively do
>> > anything to help here but equally well it's not supposed to get in the
>> > way.
>
>> The workaround to enable a cpu_dai to be used in multiple dai_links isn't
>
> What workaround?
The same as that for codec_dai.
cpu_dai is used exact the same way as codec_dai except for runtime
pointer assignment in soc_pcm_open as i mentioned already.
>> going to work as such because of cpu_dai->runtime = runtime done
>> in soc_pcm_open.
>> Luckily for codec_dai, we can use the same in more than one dai_link.
>
> Right, OK - CPU DAIs don't come up so much so I've not noticed that.
Though, from what I have seen, except atmel-pcm.c, no driver reads
snd_pcm_runtime from the cpu_dai. And atmel-pcm.c can be easily
modified to accommodate any change.
So, it seems, the member 'struct snd_pcm_runtime *' of 'struct snd_soc_dai'
is mostly unused. We can easily move it to 'struct snd_soc_dai_link' or
even drop it altogether to reduce redundancy(I prefer).
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-02-18 2:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 2:39 Separate dma driver for cpu_dais jassi brar
2010-02-17 6:58 ` Joonyoung Shim
2010-02-17 7:24 ` jassi brar
2010-02-17 7:37 ` Joonyoung Shim
2010-02-17 10:52 ` Mark Brown
2010-02-17 12:15 ` jassi brar
2010-02-17 13:14 ` Mark Brown
2010-02-18 2:14 ` jassi brar [this message]
2010-02-18 9:35 ` Mark Brown
2010-02-18 9:42 ` jassi brar
2010-02-18 9:52 ` Mark Brown
2010-02-18 10:32 ` jassi brar
2010-02-18 10:57 ` Mark Brown
2010-02-18 11:59 ` jassi brar
2010-02-18 13:10 ` Mark Brown
2010-02-23 5:45 ` jassi brar
2010-02-23 10:37 ` Mark Brown
2010-02-19 9:48 ` jassi brar
2010-02-19 9:50 ` Mark Brown
2010-02-18 6:12 ` Joonyoung Shim
2010-02-18 9:42 ` Mark Brown
2010-02-17 10:42 ` Mark Brown
2010-02-17 12:13 ` jassi brar
2010-02-17 12:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791002171814k28fccf9emcbcf17c54c445a4f@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).