From: jassi brar <jassisinghbrar@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Jassi Brar <jassi.brar@samsung.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: PCM_RATE: Check for KNOT and CONTINUOUS flags
Date: Fri, 12 Mar 2010 21:32:14 +0900 [thread overview]
Message-ID: <1b68c6791003120432j26fa5c43nfb7ee34c9b7d75c@mail.gmail.com> (raw)
In-Reply-To: <20100312111613.GA21260@rakim.wolfsonmicro.main>
On Fri, Mar 12, 2010 at 8:16 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Mar 12, 2010 at 01:38:52PM +0900, Jassi Brar wrote:
>> For ASoC, if either CPU or CODEC driver has set the flag, the MACHINE driver
>> should be given a chance to figure out if the dai, that set the flag, can
>> accomodate a rate that it does not explicitly specify but is specified
>> by the dai at the other end of the link.
>>
>> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
>
> Applied, thanks.
>
> We'll have to work out how to manage the sharing of responsibility for
> the clock configuration between the component drivers and the machine
> drivers. My first thought is to have the component drivers provide
> functions machine drivers can use if they want to. It might also be
> desirable to allow machine drivers to suppress these flags if they just
> want to use standard rates, though IIRC the core does the right thing
> anyway.
Usually even the non-standard rates, those not explicitly mentioned in the
chip's manual, are possible to generate given a suitable source of clock and
this source clock usually closely depends on the board/machine.
That suggests having the MACHINE driver decide which rates would
be supported on it (as only it knows cpu/codec dais and the source of clocks).
But functions seem overkill, the machine driver could already extract supported
rates from cpu_dai and codec_dai members of the dai_link.
So, imho, rates specified by dais should be used only by the machine driver
which, after considering the design and purpose of the device, provide a list of
supported rates to the ASoC. Of course, soc-core.c would need to be modified.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-03-12 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 4:38 [PATCH] ASoC: PCM_RATE: Check for KNOT and CONTINUOUS flags Jassi Brar
2010-03-12 8:26 ` Liam Girdwood
2010-03-12 11:16 ` Mark Brown
2010-03-12 12:32 ` jassi brar [this message]
2010-03-12 16:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791003120432j26fa5c43nfb7ee34c9b7d75c@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassi.brar@samsung.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).