From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
lgirdwood@gmail.com, "Babu, Ramesh" <ramesh.babu@intel.com>,
broonie@kernel.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH 2/7] ALSA: core: add .update_appl_ptr callback for pcm ops
Date: Mon, 3 Oct 2016 09:49:10 -0500 [thread overview]
Message-ID: <1dc416c0-e7b5-448f-4a6f-25a25d5ece5e@linux.intel.com> (raw)
In-Reply-To: <s5hintdkzbl.wl-tiwai@suse.de>
>>>> When appl_ptr is updated let low-level driver know, e.g. to let the
>>>> low-level driver/hardware pre-fetch data opportunistically.
>>>>
>>>> The existing .ack callback could be used but it would need to be
>>>> extended with new arguments, resulting in multiple changes in legacy
>>>> code.
>>>
>>> I wouldn't mind changing these callers. They aren't so many, after
>>> all.
>>
>> Yes this was one of the discussions we had in the past. I don't recall the
>> conclusion so had recommened to keep as is and discuss here.
>>
>> Do you think it's better to do that or use a new one :)
>
> It's OK to change ack callback, and actually it'll be cleaner.
> But then it'll be a problem in the next patch, I suppose :)
The main problem is test/coverage of legacy v. alignment of
functionality. If we change .ack() then others will have to test for the
changes and there's a risk of a regression on a specific platform that
wasn't tested - Murphy's law applies.
next prev parent reply other threads:[~2016-10-03 14:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 12:43 [PATCH 0/7] ALSA: Add rewinds disabled, delays, max_inflight_bytes Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 1/7] ALSA: core: let low-level driver or userspace disable rewinds Subhransu S. Prusty
2016-09-30 13:22 ` Takashi Iwai
2016-10-03 4:40 ` Subhransu S. Prusty
2016-10-03 14:39 ` Pierre-Louis Bossart
2016-10-21 15:57 ` Takashi Iwai
2016-09-30 12:43 ` [PATCH 2/7] ALSA: core: add .update_appl_ptr callback for pcm ops Subhransu S. Prusty
2016-09-30 13:24 ` Takashi Iwai
2016-09-30 17:20 ` Vinod Koul
2016-09-30 18:38 ` Takashi Iwai
2016-10-03 4:36 ` Vinod Koul
2016-10-03 14:49 ` Pierre-Louis Bossart [this message]
2016-09-30 12:43 ` [PATCH 3/7] ALSA: pcm: avoid mmap of control data if .update_appl_ptr is implemented Subhransu S. Prusty
2016-09-30 13:40 ` Takashi Iwai
2016-10-03 4:43 ` Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 4/7] ALSA: core: add report of max inflight bytes Subhransu S. Prusty
2016-09-30 13:44 ` Takashi Iwai
2016-09-30 12:43 ` [PATCH 5/7] ALSA: hda: add default value for max_inflight_bytes Subhransu S. Prusty
2016-10-03 8:48 ` Hardik Shah
2016-10-03 14:44 ` Pierre-Louis Bossart
2016-09-30 12:43 ` [PATCH 6/7] ALSA: usb: no_period_wake and max_inflight_bytes report Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 7/7] ALSA: usb: take startup delay into account Subhransu S. Prusty
2016-09-30 13:44 ` Takashi Iwai
2016-10-03 15:04 ` Pierre-Louis Bossart
2016-10-21 16:00 ` Takashi Iwai
2016-10-03 6:46 ` Takashi Sakamoto
2016-10-03 15:08 ` Pierre-Louis Bossart
2016-10-03 17:31 ` Takashi Sakamoto
2016-09-30 13:13 ` [PATCH 0/7] ALSA: Add rewinds disabled, delays, max_inflight_bytes Takashi Iwai
2016-10-03 4:28 ` Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc416c0-e7b5-448f-4a6f-25a25d5ece5e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=ramesh.babu@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).