From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Lubomir Rintel <lkundrak@v3.sk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date: Thu, 27 Apr 2017 19:49:04 +0100 [thread overview]
Message-ID: <1fa94590-3dbf-922d-4fe7-1a507eec4b32@synopsys.com> (raw)
In-Reply-To: <20170421104915.x7gxt5yqcuewa7rv@sirena.org.uk>
Hi,
On 21-04-2017 11:49, Mark Brown wrote:
> On Fri, Apr 21, 2017 at 12:39:30PM +0200, Takashi Iwai wrote:
>> Jose Abreu wrote:
>>> Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
>>> called "dwc") and let the module still be called "designware-i2s"?
>> Lubomir's patch keeps the module name intact. My point is that rename
>> of a file isn't nice to look at the git commit history, so it's better
>> to be avoided as much as possible. But in this case, it looks
>> unavoidable.
> Right. Renaming the source file is the lesser evil, it's possible
> people might have the module name in their configuration for their
> systems somewhere.
I agree. I just noticed today that without a valid license tag we
get unresolved symbols when inserting pcm module so this patch is
really needed as a fix.
Lubomir, could you address the review comments and resend? If you
are not available let me know and I will fix and resend the patch
with your sign-off.
Best regards,
Jose Miguel Abreu
prev parent reply other threads:[~2017-04-27 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 10:59 [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel
2017-04-18 15:18 ` Mark Brown
2017-04-18 16:13 ` Lubomir Rintel
2017-04-18 17:15 ` Mark Brown
2017-04-19 16:12 ` Jose Abreu
2017-04-19 16:14 ` Lubomir Rintel
2017-04-19 16:48 ` Jose Abreu
2017-04-20 19:46 ` Mark Brown
2017-04-20 20:24 ` Takashi Iwai
2017-04-20 20:25 ` Mark Brown
2017-04-21 10:34 ` Jose Abreu
2017-04-21 10:39 ` Takashi Iwai
2017-04-21 10:49 ` [alsa-devel] " Mark Brown
2017-04-27 18:49 ` Jose Abreu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fa94590-3dbf-922d-4fe7-1a507eec4b32@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).