From: Jerome Brunet <jbrunet@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 2/7] ASoC: dt-bindings: meson: convert axg tdm formatters to schema
Date: Tue, 07 Feb 2023 10:29:51 +0100 [thread overview]
Message-ID: <1j7cwt3jm1.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <167571334291.1212116.1869881432057405431.robh@kernel.org>
On Mon 06 Feb 2023 at 13:59, Rob Herring <robh@kernel.org> wrote:
> On Mon, 06 Feb 2023 16:34:44 +0100, Jerome Brunet wrote:
>> Convert the DT binding documentation for the Amlogic tdm formatters to
>> schema.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>> .../sound/amlogic,axg-tdm-formatters.txt | 36 --------
>> .../sound/amlogic,axg-tdm-formatters.yaml | 88 +++++++++++++++++++
>> 2 files changed, 88 insertions(+), 36 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.txt
>> create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml:
> Unable to find schema file matching $id:
> http://devicetree.org/schemas/sound/component-common.yaml
This is a false error because the bot does not have the patch applied
by Mark from v1 here [0]
[0]: https://lore.kernel.org/all/167543616131.928818.17902040818579023398.b4-ty@kernel.org/
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.example.dtb:
> audio-controller@500: False schema does not allow {'compatible':
> ['amlogic,g12a-tdmout'], 'reg': [[1280, 64]], 'resets': [[4294967295, 12]],
> 'clocks': [[4294967295, 35], [4294967295, 127], [4294967295, 120],
> [4294967295, 134], [4294967295, 134]], 'clock-names': ['pclk', 'sclk',
> 'sclk_sel', 'lrclk', 'lrclk_sel'], '$nodename': ['audio-controller@500']}
> From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230206153449.596326-3-jbrunet@baylibre.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-02-07 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:34 [PATCH v2 0/7] ASoC: dt-bindings: meson: covert axg audio to schema Jerome Brunet
2023-02-06 15:34 ` [PATCH v2 1/7] ASoC: dt-bindings: meson: convert axg tdm interface " Jerome Brunet
2023-02-06 19:10 ` Krzysztof Kozlowski
2023-02-06 15:34 ` [PATCH v2 2/7] ASoC: dt-bindings: meson: convert axg tdm formatters " Jerome Brunet
2023-02-06 19:12 ` Krzysztof Kozlowski
2023-02-06 19:59 ` Rob Herring
2023-02-07 9:29 ` Jerome Brunet [this message]
2023-02-07 13:50 ` Rob Herring
2023-02-06 15:34 ` [PATCH v2 3/7] ASoC: dt-bindings: meson: convert axg pdm " Jerome Brunet
2023-02-06 19:13 ` Krzysztof Kozlowski
2023-02-06 15:34 ` [PATCH v2 4/7] ASoC: dt-bindings: meson: convert axg fifo " Jerome Brunet
2023-02-06 19:14 ` Krzysztof Kozlowski
2023-02-06 15:34 ` [PATCH v2 5/7] ASoC: dt-bindings: meson: convert axg spdif input " Jerome Brunet
2023-02-06 19:15 ` Krzysztof Kozlowski
2023-02-06 15:34 ` [PATCH v2 6/7] ASoC: dt-bindings: meson: convert axg spdif output " Jerome Brunet
2023-02-06 19:16 ` Krzysztof Kozlowski
2023-02-06 15:34 ` [PATCH v2 7/7] ASoC: dt-bindings: meson: convert axg sound card control " Jerome Brunet
2023-02-06 19:21 ` Krzysztof Kozlowski
2023-02-07 9:25 ` Jerome Brunet
2023-02-07 12:30 ` Krzysztof Kozlowski
2023-02-07 15:06 ` (subset) [PATCH v2 0/7] ASoC: dt-bindings: meson: covert axg audio " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j7cwt3jm1.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox