Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pedro Lopez-Cabanillas <plcl@telefonica.net>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: [PATCH] usbmidi (0.9.0rc7) output endpoints detection for MIDIStreaming protocol
Date: Mon, 3 Feb 2003 00:56:26 +0100	[thread overview]
Message-ID: <200302030056.26089.plcl@telefonica.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi,

Attached is a patch to solve a little mistake with output endpoints detection 
for standard USB MIDI devices. Midisport devices are affected only if using 
Lars Doelle firmware.

Typical syslog output was like this:

kernel: snd-usb-midi: MIDIStreaming version 01.00
kernel: snd-usb-midi: EP 01: 2 jack(s)
kernel: snd-usb-midi: EP 81: 2 jack(s)
kernel: snd-usb-midi: created 0 output and 4 input ports
kernel: usb-uhci.c: ENXIO c0008480, flags 0, urb c1b665a0, burb c1b664a0
kernel: snd-usb-midi: usb_submit_urb: -6

Regards,
Pedro

-- 
ALSA Library Bindings for Pascal
http://alsapas.alturl.com

[-- Attachment #2: patch.usbmidi --]
[-- Type: text/x-diff, Size: 540 bytes --]

--- alsa-kernel/usb/usbmidi.c.old	Mon Jan 13 10:50:26 2003
+++ alsa-kernel/usb/usbmidi.c	Mon Feb  3 00:41:36 2003
@@ -821,7 +821,7 @@
 		    ms_ep->bDescriptorType != USB_DT_CS_ENDPOINT ||
 		    ms_ep->bDescriptorSubtype != MS_GENERAL)
 			continue;
-		if ((ep->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK) == USB_DIR_OUT) {
+		if ((ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT) {
 			if (endpoints[epidx].out_ep) {
 				if (++epidx >= MIDI_MAX_ENDPOINTS) {
 					printk(KERN_WARNING "snd-usb-midi: too many endpoints\n");

             reply	other threads:[~2003-02-02 23:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-02 23:56 Pedro Lopez-Cabanillas [this message]
2003-02-03  9:59 ` [PATCH] usbmidi (0.9.0rc7) output endpoints detection for MIDIStreaming protocol Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302030056.26089.plcl@telefonica.net \
    --to=plcl@telefonica.net \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=clemens@ladisch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox