From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
mingo@elte.hu, rlrevell@joe-job.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org,
gordon.jin@intel.com, alsa-devel@lists.sourceforge.net,
greg@kroah.com
Subject: Re: [PATCH] unregister_ioctl32_conversion and modules. ioctl32 revisited.
Date: Thu, 16 Dec 2004 16:08:11 +0000 [thread overview]
Message-ID: <20041216160811.GA9641@infradead.org> (raw)
In-Reply-To: <20041217014345.GA11926@mellanox.co.il>
> + long (*ioctl_native) (struct inode *, struct file *, unsigned int,
> + unsigned long);
> + long (*ioctl_compat) (struct inode *, struct file *, unsigned int,
> + unsigned long);
Please remove the struct inode * argument, it's easily retrievable
from file->f_dentry->d_inode. The ioctl prototype is a leftover from
really old days where that wasn't true.
next prev parent reply other threads:[~2004-12-16 16:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041215065650.GM27225@wotan.suse.de>
[not found] ` <20041215074635.GC11501@mellanox.co.il>
[not found] ` <s5hbrcvqv7r.wl@alsa2.suse.de>
2004-12-15 18:30 ` unregister_ioctl32_conversion and modules. ioctl32 revisited Lee Revell
2004-12-15 19:34 ` Michael S. Tsirkin
2004-12-16 5:03 ` [discuss] " Andi Kleen
2004-12-16 7:53 ` Ingo Molnar
2004-12-16 8:09 ` Andi Kleen
2004-12-16 8:25 ` Andrew Morton
2004-12-16 8:30 ` Michael S. Tsirkin
2004-12-16 8:38 ` Andi Kleen
2004-12-17 1:43 ` [PATCH] " Michael S. Tsirkin
2004-12-16 16:08 ` Christoph Hellwig [this message]
[not found] ` <20050103011113.6f6c8f44.akpm@osdl.org>
2005-01-05 14:40 ` [PATCH] deprecate (un)register_ioctl32_conversion Michael S. Tsirkin
2005-01-05 14:46 ` Christoph Hellwig
2005-01-05 15:03 ` Michael S. Tsirkin
2005-01-05 15:11 ` Christoph Hellwig
2005-01-05 21:33 ` Andrew Morton
2005-01-06 14:41 ` Michael S. Tsirkin
2005-01-06 14:55 ` Christoph Hellwig
2005-01-06 15:22 ` Michael S. Tsirkin
2005-01-06 15:30 ` Christoph Hellwig
2005-01-06 15:56 ` Michael S. Tsirkin
2005-01-05 15:19 ` Andi Kleen
2005-01-05 15:55 ` Christoph Hellwig
2005-01-05 18:23 ` Takashi Iwai
2005-01-05 21:34 ` Andrew Morton
2005-01-06 14:06 ` [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat Michael S. Tsirkin
2005-01-06 14:53 ` Christoph Hellwig
2005-01-06 15:09 ` Andi Kleen
[not found] ` <20050106151429.GA19155@infradead.org>
2005-01-06 15:22 ` Lee Revell
[not found] ` <20050106153147.GB19324@infradead.org>
[not found] ` <1105025938.14990.4.camel@krustophenia.net>
[not found] ` <20050106154327.GA19781@infradead.org>
2005-01-06 16:21 ` new home for alsa-devel archive? (was Re: [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat) Lee Revell
2005-01-06 17:55 ` new home for alsa-devel archive? Måns Rullgård
2005-01-07 4:26 ` Eric Dantan Rzewnicki
2005-01-06 16:35 ` [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat Petr Vandrovec
2005-01-06 16:39 ` Christoph Hellwig
2005-01-06 16:57 ` Andi Kleen
2005-01-06 17:26 ` Petr Vandrovec
2005-01-06 22:34 ` Pavel Machek
2005-01-12 20:36 ` [PATCH] fix: macros to detect existance of unlocked_ioctl and compat_ioctl Michael S. Tsirkin
2005-01-12 21:29 ` Greg KH
2005-01-12 21:43 ` Andi Kleen
2005-01-12 22:52 ` Greg KH
2005-01-12 23:10 ` Andrew Morton
2005-01-12 23:16 ` Greg KH
[not found] ` <20050119213818.55b14bb0.akpm@osdl.org>
2005-01-21 0:09 ` security hook missing in compat ioctl in 2.6.11-rc1-mm2 Michael S. Tsirkin
2005-01-21 0:10 ` Chris Wright
2005-01-21 1:26 ` [PATCH] compat ioctl security hook fixup Chris Wright
2005-01-21 4:19 ` Andi Kleen
2005-01-21 5:51 ` Chris Wright
2005-01-21 6:11 ` Andi Kleen
2005-01-21 6:35 ` [PATCH] compat ioctl security hook fixup (take2) Chris Wright
[not found] ` <20050106002240.00ac4611.akpm@osdl.org>
2005-01-06 14:51 ` [PATCH] fget_light/fput_light for ioctls Michael S. Tsirkin
2005-01-06 16:18 ` [PATCH] fget_light/fput_light for ioctls (fixed) Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041216160811.GA9641@infradead.org \
--to=hch@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=discuss@x86-64.org \
--cc=gordon.jin@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@mellanox.co.il \
--cc=pavel@suse.cz \
--cc=rlrevell@joe-job.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox