Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Langer <martin-langer@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] compiling problem fixed
Date: Wed, 11 May 2005 20:54:59 +0200	[thread overview]
Message-ID: <20050511185459.GA2962@tuba> (raw)
In-Reply-To: <s5hoebh292c.wl@alsa2.suse.de>

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Wed, May 11, 2005 at 03:20:27PM +0200, Takashi Iwai wrote:
> At Tue, 3 May 2005 16:29:16 +0200,
> Martin Langer wrote:
> > 
> > This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.
> 
> It's not nice to put to this place.  It always includes the file.

Ah sorry, I see your point. Next time I should scroll down in my 
editor, before I create a patch :)

> Where does this error happen?  In the gameport wrapper inline
> function?  

Yep, it's in the gameport wrapper inline function. So now it's 
placed closer to that wrapper function.

---
Fix undeclared GFP_KERNEL in gameport wrapper inline function. Compile 
error happened with debian kernel 2.4.27 (alpha cpu).

Signed-off-by: Martin Langer <martin-langer@gmx.de>
---

BTW, the miroSOUND PCM12 with the new miro driver is running great, even 
on my alpha machine here :)


martin

[-- Attachment #2: adriver.patch --]
[-- Type: text/plain, Size: 318 bytes --]

--- include/adriver.h.ORIGINAL	2005-05-03 15:57:09.000000000 +0200
+++ include/adriver.h	2005-05-11 20:18:38.000000000 +0200
@@ -749,6 +749,7 @@
 #include <linux/gameport.h>
 #undef wait_ms
 #ifndef to_gameport_driver
+#include <linux/slab.h>
 /* old gameport interface */
 struct snd_gameport {
 	struct gameport gp;

  reply	other threads:[~2005-05-11 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-03 14:29 [PATCH] compiling problem fixed Martin Langer
2005-05-11 13:20 ` Takashi Iwai
2005-05-11 18:54   ` Martin Langer [this message]
2005-05-12  9:07     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050511185459.GA2962@tuba \
    --to=martin-langer@gmx.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox