From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Khapyorsky Subject: Re: [PATCH] hda-intel, correct a bug in detection of rate supported Date: Sat, 20 Aug 2005 02:19:57 +0300 Message-ID: <20050819231956.GA11604@tecr> References: <43063A3E.4010903@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from sa5.bezeqint.net (sa5.bezeqint.net [192.115.104.19]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 6D60F1DB for ; Sat, 20 Aug 2005 01:03:22 +0200 (MEST) Content-Disposition: inline In-Reply-To: <43063A3E.4010903@free.fr> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Nicolas GRAZIANO Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 21:59 Fri 19 Aug , Nicolas GRAZIANO wrote: > The insertion of the rate 9600 make a shift in detection of supported > rate, put this rate at the end of the list. Good point. Thanks for fixing. Sasha. > > Signed-off-by: Nicolas Graziano > > > Index: pci/hda/hda_codec.c > =================================================================== > RCS file: /cvsroot/alsa/alsa-kernel/pci/hda/hda_codec.c,v > retrieving revision 1.23 > diff -u -r1.23 hda_codec.c > --- pci/hda/hda_codec.c 11 Aug 2005 10:00:16 -0000 1.23 > +++ pci/hda/hda_codec.c 19 Aug 2005 19:43:51 -0000 > @@ -1165,8 +1165,9 @@ > */ > static unsigned int rate_bits[][3] = { > /* rate in Hz, ALSA rate bitmask, HDA format value */ > + > + /* autodetected value used in snd_hda_query_supported_pcm */ > { 8000, SNDRV_PCM_RATE_8000, 0x0500 }, /* 1/6 x 48 */ > - { 9600, SNDRV_PCM_RATE_KNOT, 0x0400 }, /* 1/5 x 48 */ > { 11025, SNDRV_PCM_RATE_11025, 0x4300 }, /* 1/4 x 44 */ > { 16000, SNDRV_PCM_RATE_16000, 0x0200 }, /* 1/3 x 48 */ > { 22050, SNDRV_PCM_RATE_22050, 0x4100 }, /* 1/2 x 44 */ > @@ -1177,6 +1178,9 @@ > { 96000, SNDRV_PCM_RATE_96000, 0x0800 }, /* 2 x 48 */ > { 176400, SNDRV_PCM_RATE_176400, 0x5800 },/* 4 x 44 */ > { 192000, SNDRV_PCM_RATE_192000, 0x1800 }, /* 4 x 48 */ > + > + /* not autodetected value */ > + { 9600, SNDRV_PCM_RATE_KNOT, 0x0400 }, /* 1/5 x 48 */ > { 0 } > }; > > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/alsa-devel ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf