From: Grant Grundler <grundler@parisc-linux.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Thibaut VARENE <T-Bone@parisc-linux.org>,
alsa-devel@lists.sourceforge.net,
parisc-linux@lists.parisc-linux.org, kyle@parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip
Date: Fri, 19 Aug 2005 19:36:55 -0600 [thread overview]
Message-ID: <20050820013655.GC6376@colo.lackof.org> (raw)
In-Reply-To: <s5hr7cpdd9p.wl%tiwai@suse.de>
On Fri, Aug 19, 2005 at 07:53:22PM +0200, Takashi Iwai wrote:
> Check his patch carefully. It doesn't add any extra accesses (except
> for one readl to flush in irq handler - I guess it was added to be
> sure?). The original driver didn't use these fields effectively at
> all, too.
Sorry - I didn't look at patch at all.
If the fields were never used, removing them is fine.
If they *could* have been used, then removing them is a bad idea.
In general, referencing parameters in IO device registers is NOT
a good substitute for caching the values "locally" in host mem.
hth,
grant
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
next prev parent reply other threads:[~2005-08-20 1:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 19:16 [PATCH] Support for AD1889 PCI Soundchip Thibaut VARENE
2005-07-29 19:20 ` [parisc-linux] " Thibaut VARENE
2005-08-03 13:46 ` Takashi Iwai
2005-08-04 13:30 ` [parisc-linux] " Clemens Ladisch
2005-08-11 15:18 ` Clemens Ladisch
2005-08-12 2:14 ` Kyle McMartin
2005-08-12 7:17 ` Clemens Ladisch
2005-08-17 1:51 ` Kyle McMartin
2005-08-17 13:50 ` Clemens Ladisch
2005-08-17 9:10 ` Thibaut VARENE
2005-08-18 15:35 ` Clemens Ladisch
2005-08-18 17:12 ` Lee Revell
2005-08-19 17:46 ` Grant Grundler
2005-08-19 17:53 ` Takashi Iwai
2005-08-20 1:36 ` Grant Grundler [this message]
2005-08-22 11:03 ` Takashi Iwai
2005-08-23 0:13 ` Grant Grundler
2005-08-23 9:11 ` Takashi Iwai
2005-08-28 12:57 ` Thibaut VARENE
2005-08-31 2:26 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050820013655.GC6376@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=T-Bone@parisc-linux.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=clemens@ladisch.de \
--cc=kyle@parisc-linux.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox