Re: ac97 oops in ali modem driver

[Sasha Khapyorsky <sashak@smlink.com>]

On 13:05 Tue 04 Oct     , Takashi Iwai wrote:
> At Mon, 3 Oct 2005 17:34:48 +0300,
> Sasha Khapyorsky wrote:
> > 
> > On 21:01 Sun 02 Oct     , Dave Jones wrote:
> > > I just had a user file a Fedora bug with the following oops.
> > 
> > Is there other messages from ali5451 loading? The sound works I guess?
> > What do you see when 'ls /proc/asound/ali5451/codec97#0'?
> 
> Maybe the probe of secondary codec failed?
> Then the patch below might fix.

Quite possible and we expect to see something about it in dmesg.
The patch is obviously correct and will help in such cases. Frankly I
would prefer like this:


--- alsa-kernel/pci/ali5451/ali5451.c	4 Oct 2005 12:50:44 -0000	1.73
+++ alsa-kernel/pci/ali5451/ali5451.c	4 Oct 2005 23:06:43 -0000
@@ -1844,7 +1844,7 @@ static int __devinit snd_ali_build_pcms(
 {
 	int i, err;
 	for(i = 0 ; i < codec->num_of_codecs && i < ARRAY_SIZE(ali_pcms) ; i++)
-		if((err = snd_ali_pcm(codec, i, &ali_pcms[i])) < 0)
+		if(codec->ac97[i] && (err = snd_ali_pcm(codec, i, &ali_pcms[i])) < 0)
 			return err;
 	return 0;
 }


So it will be "more" on controller's side. But not critical.

Thanks,
Sasha.

> 
> 
> --- linux/sound/pci/ali5451/ali5451.c	29 Sep 2005 10:47:07 -0000	1.71
> +++ linux/sound/pci/ali5451/ali5451.c	4 Oct 2005 11:03:38 -0000
> @@ -1994,8 +1994,10 @@
>  		if ((err = snd_ac97_mixer(codec->ac97_bus, &ac97, &codec->ac97[i])) < 0) {
>  			snd_printk("ali mixer %d creating error.\n", i);
>  			if(i == 0)
> -		return err;
> -	}
> +				return err;
> +			codec->num_of_codecs = 1;
> +			break;
> +		}
>  	}
>  
>  	if (codec->spdif_support) {
> 


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl