From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: ALSA on MIPS platform Date: Tue, 7 Aug 2007 18:54:02 +0100 Message-ID: <20070807175402.GA24731@linux-mips.org> References: <46B332AC.8020403@lemote.com> <5861a7880708062253x7133659cm1ff17f451e4f82f8@mail.gmail.com> <5861a7880708062317t21970c81w3f16580858bf50af@mail.gmail.com> <20070807.230157.59463765.anemo@mba.ocn.ne.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ftp.linux-mips.org (ftp.linux-mips.org [194.74.144.162]) by alsa0.perex.cz (Postfix) with ESMTP id C0E7C1038FE for ; Tue, 7 Aug 2007 19:54:16 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:40138 "EHLO dl5rb.ham-radio-op.net") by ftp.linux-mips.org with ESMTP id S20024469AbXHGRyN (ORCPT ); Tue, 7 Aug 2007 18:54:13 +0100 Content-Disposition: inline In-Reply-To: <20070807.230157.59463765.anemo@mba.ocn.ne.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Atsushi Nemoto Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, tiwai@suse.de, greg@kroah.com, tiansm@lemote.com, jiankemeng@gmail.com List-Id: alsa-devel@alsa-project.org On Tue, Aug 07, 2007 at 11:01:57PM +0900, Atsushi Nemoto wrote: > On Tue, 7 Aug 2007 10:18:04 +0400, "Dajie Tan" wrote: > > static inline unsigned long virt_to_phys(volatile const void *address) > > { > > - return (unsigned long)address - PAGE_OFFSET + PHYS_OFFSET; > > + return ((unsigned long)address & 0x1fffffff) + PHYS_OFFSET; > > } > > This makes virt_to_phys() a bit slower, and more importantly, breaks > 64-bit kernel. It's ALSA that is doing funny things here so there is no point in fixing the arch code to work for ALSA. Ralf