From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: eric miao <eric.y.miao@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 1/3] soc - pxa2xx-ac97: Add missing clk_enable()
Date: Tue, 15 Apr 2008 13:29:06 +0100 [thread overview]
Message-ID: <20080415122906.GC24498@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <f17812d70804150432t1fd0e20cpedaba34b47eb807d@mail.gmail.com>
On Tue, Apr 15, 2008 at 07:32:39PM +0800, eric miao wrote:
> It looks a bit confused between the commit message and the actual change.
> My understanding would be the pxa{25x,27x} requires this change (adding
> clk_enable), but pxa3xx does not require this. So actually the change is
> addressing some issue on pxa{25x,27x}?
For correctness WRT the clock API it's required on all variants - the
note about PXA3xx is just to indicate how it got through testing.
next prev parent reply other threads:[~2008-04-15 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 15:11 PXA AC97 updates Mark Brown
2008-04-14 15:12 ` [PATCH 1/3] soc - pxa2xx-ac97: Add missing clk_enable() Mark Brown
2008-04-14 15:12 ` [PATCH 2/3] pxa2xx-ac97: Support PXA3xx AC97 Mark Brown
2008-04-14 15:12 ` [PATCH 3/3] soc - " Mark Brown
2008-04-15 14:08 ` [PATCH 2/3] pxa2xx-ac97: " eric miao
2008-04-15 14:19 ` [alsa-devel] " Mark Brown
2008-04-15 11:32 ` [PATCH 1/3] soc - pxa2xx-ac97: Add missing clk_enable() eric miao
2008-04-15 12:29 ` Mark Brown [this message]
2008-04-15 14:11 ` eric miao
2008-04-15 14:36 ` Mark Brown
2008-04-14 15:13 ` PXA AC97 updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415122906.GC24498@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox