From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) Date: Tue, 13 May 2008 18:01:07 +0100 Message-ID: <20080513180107.1a3893f1@core> References: <4823AAF2.7070102@keyaccess.nl> <200805131059.32911.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from lxorguk.ukuu.org.uk (unknown [81.2.110.250]) by alsa0.perex.cz (Postfix) with ESMTP id 2107E24B4E for ; Tue, 13 May 2008 19:11:36 +0200 (CEST) In-Reply-To: <200805131059.32911.bjorn.helgaas@hp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Bjorn Helgaas Cc: Thomas@alsa-project.org, ALSA devel , Takashi Iwai , Rene Herman , Linux Kernel , Glauber Costa , Pete Clements , Gleixner , Ingo Molnar List-Id: alsa-devel@alsa-project.org On Tue, 13 May 2008 10:59:32 -0600 Bjorn Helgaas wrote: > On Friday 09 May 2008 12:06:55 am Takashi Iwai wrote: > > Thanks for catching it. Yeah, the patch looks buggy. We had an > > implicit assumption that dev = NULL for ISA devices that require 24bit > > DMA. > > Naive question #1: Why don't we have a struct device for these > ISA devices? PNP builds a struct device with DMA_24BIT_MASK > for ISAPNP devices. Because nobody has done the needed work to get all the old ISA drivers converted. I guess isa_device would actually be a platform_device wrapper ?