Re: AT32AP7000 (AVR32) + WM8510

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Tue, May 27, 2008 at 10:16:56AM -0500, Geoffrey Wossum wrote:

> FRAME as well as BCLK.  I might give the WM8510 a try as the master again, 
> since I can get the sample rates closer with it.

Let me know how that goes, please.

> It seems like the other CODEC drivers will eventually need to use the 
> auto-endian constants, especially if big endian microcontrollers like the 
> AVR32 catch on.

If anything offering both big endian and little endian seems best - that
will allow the host controller to offer whatever memory formats it feels
like offering.

> I'm attaching my final patch to sound/soc/codecs/wm8510.c (again, this is 
> against a 2.6.24 kernel).  I noticed that there seems to be a misprint in the 

Thanks - as I said previously it's much better if you can include a
Signed-off-by line in patch submissions in order to allow them to be
submitted to the mainline kernel, though in the case of fairly obvious
register access fixes like these it's generally not an obstacle.

> WM8510 datasheet.  Register 0x32 (SPKMIX) seems to have a different default 

> value than what is in the datasheet.  Also, the driver never configured CLKSEL 
I'll take a look.

> to run the CODEC from PLL.  I changed wm8510_set_dai_pll() to automatically 
> set CLKSEL when the PLL is started, and to clear CLKSEL when the PLL is 
> turned off.  It doesn't seem like anyone would ever configure the PLL if they 
> didn't want to use the PLL.

Yup, and that's exactly what most of our codec drivers do.  I'll apply
this fix to the driver - thanks!