Re: [PATCH] Fix buffer position for ATI SB4x0

[Mauro Carvalho Chehab <mchehab@infradead.org>]

On Thu, 29 May 2008 16:20:21 +0200
Takashi Iwai <tiwai@suse.de> wrote:

> At Thu, 29 May 2008 11:10:22 -0300,
> Mauro Carvalho Chehab wrote:
> > 
> > ATI SB4x0 doesn't need any fix at position.
> 
> It's not about the position fixing but whether to use the
> position-buffer.  The devices on the blacklist are the ones that have
> no position buffer.  So, it would fall into LPIB mode, and this list
> avoids it from the beginning.

Sometimes, I get this message:

[  857.014011] hda-intel: Invalid position buffer, using LPIB read method instead.

It is weird, since this line doesn't appear always.

> > This patch solves the issue of receiving several clicks during capture on those
> > devices.
> > 
> > Tested with a Gateway Notebook MX-6453.
> 
> The click noise is often a different problem.  Did you already try
> the patch below?

This patch is already here on my testing environment.

There are a few reports I found at the net about Gateway devices with SB450 ATI
chipset. Some suggestions for working with MIC pointed the need of using
position_fix=0 to avoid the clicks on those devices.


One weird thing is that I've did this procedure, when I generated the patch:
	- tested without the patch - clicks at mic;
	- applied the patch I sent - no clicks;
	- removed the patch after your email - no clicks;
	- reapplied/removed several times - no clicks.

I'll try today to test with and without the position fix after cold boot/soft
boot/resume. Maybe there are some registers that aren't properly initialized on
some cases.

Btw, after a suspend/resume, some widgets aren't properly restored (at
mercurial tree version). For example, if I suspend with master Mute on, after
resume, mute is off (but the kmix still shows it as muted). I'm not sure if the
clicks happen after resume. I'll double check it.

Cheers,
Mauro