Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ext-jukka.hynninen@vaisala.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC WM8510 Mic PGA problem
Date: Tue, 7 Oct 2008 15:59:34 +0100	[thread overview]
Message-ID: <20081007145934.GA32344@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <B9D3C48C98930741A166756A50C44A610F17B55E@helx1.corp.vaisala.com>

On Tue, Oct 07, 2008 at 05:21:48PM +0300, ext-jukka.hynninen@vaisala.com wrote:

> I'm sorry, It seems to be the switch connecting MICN to negative PGA
> terminal that does not stay on (register 0x2c bit 1)

Ah, I think I see what's going on here.  Could you try this patch,
please (again, untested)?

diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c
index 94cab49..ea524c4 100644
--- a/sound/soc/codecs/wm8510.c
+++ b/sound/soc/codecs/wm8510.c
@@ -227,9 +227,9 @@ SND_SOC_DAPM_PGA("SpkN Out", WM8510_POWER3, 5, 0, NULL, 0),
 SND_SOC_DAPM_PGA("SpkP Out", WM8510_POWER3, 6, 0, NULL, 0),
 SND_SOC_DAPM_PGA("Mono Out", WM8510_POWER3, 7, 0, NULL, 0),
 
-SND_SOC_DAPM_PGA("Mic PGA", WM8510_POWER2, 2, 0,
-		 &wm8510_micpga_controls[0],
-		 ARRAY_SIZE(wm8510_micpga_controls)),
+SND_SOC_DAPM_MIXER("Mic PGA", WM8510_POWER2, 2, 0,
+		   &wm8510_micpga_controls[0],
+		   ARRAY_SIZE(wm8510_micpga_controls)),
 SND_SOC_DAPM_MIXER("Boost Mixer", WM8510_POWER2, 4, 0,
 	&wm8510_boost_controls[0],
 	ARRAY_SIZE(wm8510_boost_controls)),

  parent reply	other threads:[~2008-10-07 14:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 13:20 ASoC WM8510 Mic PGA problem ext-jukka.hynninen
2008-10-03 13:39 ` Mark Brown
2008-10-06  7:20   ` ext-jukka.hynninen
2008-10-06 10:05     ` Mark Brown
2008-10-06 10:53       ` ext-jukka.hynninen
2008-10-07 12:11         ` Mark Brown
2008-10-07 13:29           ` ext-jukka.hynninen
2008-10-07 13:43             ` Mark Brown
2008-10-07 14:21               ` ext-jukka.hynninen
2008-10-07 14:27                 ` Mark Brown
2008-10-07 14:59                 ` Mark Brown [this message]
2008-10-08  6:37                   ` ext-jukka.hynninen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081007145934.GA32344@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ext-jukka.hynninen@vaisala.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox