From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: Warn when control names are truncated
Date: Wed, 29 Oct 2008 14:33:16 +0000 [thread overview]
Message-ID: <20081029143316.GA27763@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <s5hej1zmq59.wl%tiwai@suse.de>
On Wed, Oct 29, 2008 at 03:28:50PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > - if (ncontrol->name)
> > + if (ncontrol->name) {
> > + if (strlen(ncontrol->name) > sizeof(kctl.id.name))
> This should be '>=' since strlen() doesn't count the terminator.
Oh, sorry - I'd misread strlcpy() as strncpy() (which would mean that
the termination character wasn't needed).
next prev parent reply other threads:[~2008-10-29 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 14:14 [PATCH] ALSA: Warn when control names are truncated Mark Brown
2008-10-29 14:28 ` Takashi Iwai
2008-10-29 14:33 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-29 14:40 Mark Brown
2008-10-29 14:46 ` Takashi Iwai
2008-10-29 14:51 ` Jaroslav Kysela
2008-10-29 14:55 ` Takashi Iwai
2008-10-29 18:31 ` Jaroslav Kysela
2008-10-29 19:00 ` Takashi Iwai
2008-10-29 14:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029143316.GA27763@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox