From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix Date: Wed, 12 Nov 2008 15:25:50 +0000 Message-ID: <20081112152549.GH8767@sirena.org.uk> References: <20081112115507.GA22288@rakim.wolfsonmicro.main> <1226490949-22360-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1226490949-22360-2-git-send-email-broonie@opensource.wolfsonmicro.com> <20081112151036.GE8767@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 1143724493 for ; Wed, 12 Nov 2008 16:25:51 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Christian Pellegrin , Christian Pellegrin List-Id: alsa-devel@alsa-project.org On Wed, Nov 12, 2008 at 04:16:08PM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > The global variable is used to tell the DMA driver how to set the > > hardware up for the port. Since the variable is tied to the underlying > > hardware channel it's used for there's no real win from duplicating it > > into a variable - the hardware it is used to configure can't be shared. > I know it, but it's still uncomfortable that such secret mythes and > legends are underlying without explanation. Could you add some more > comments around that code to avoid misunderstanding by readers? Hrm, that's a fairly standard idiom for ASoC DMA/DAI driver interaction so probably more of a Documentation/ thing but doing it there is not too helpful for addressing your concern. I'll have a think.