Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <wfg@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>
Subject: [PATCH 2/7] hda - report selected CA index for Audio InfoFrame
Date: Sat, 22 Nov 2008 09:40:52 +0800	[thread overview]
Message-ID: <20081122014308.926922791@linux.intel.com> (raw)
In-Reply-To: 20081122014050.348491872@linux.intel.com

[-- Attachment #1: alsa-report-ca.patch --]
[-- Type: text/plain, Size: 966 bytes --]

Print some CA selecting info, which could be valuable for debugging when
something goes wrong.

Signed-off-by: Wu Fengguang <wfg@linux.intel.com>
---
 sound/pci/hda/patch_intelhdmi.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

--- sound-2.6.orig/sound/pci/hda/patch_intelhdmi.c
+++ sound-2.6/sound/pci/hda/patch_intelhdmi.c
@@ -444,14 +444,16 @@ static int hdmi_setup_channel_allocation
 		    (spk_mask & channel_allocations[i].spk_mask) ==
 				channel_allocations[i].spk_mask) {
 			ai->CA = channel_allocations[i].ca_index;
-			return 0;
+			break;
 		}
 	}
 
 	snd_print_channel_allocation(eld->spk_alloc, buf, sizeof(buf));
-	snd_printd(KERN_INFO "failed to setup channel allocation: %d of %s\n",
-			channels, buf);
-	return -1;
+	snd_printdd(KERN_INFO
+			"HDMI: select CA 0x%x for %d-channel allocation: %s\n",
+			ai->CA, channels, buf);
+
+	return ai->CA;
 }
 
 static void hdmi_setup_channel_mapping(struct hda_codec *codec,

-- 

  parent reply	other threads:[~2008-11-22  3:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-22  1:40 [PATCH 0/7] minor HDMI cleanups and fixes Wu Fengguang
2008-11-22  1:40 ` [PATCH 1/7] hda - minor HDMI code cleanups Wu Fengguang
2008-11-22  1:40 ` Wu Fengguang [this message]
2008-11-22  1:40 ` [PATCH 3/7] hda - make HDMI messages more user friendly Wu Fengguang
2008-11-22  1:40 ` [PATCH 4/7] hda - ELD proc interface write updates Wu Fengguang
2008-11-22  1:40 ` [PATCH 5/7] hda - document the ELD proc interface Wu Fengguang
2008-11-22  1:40 ` [PATCH 6/7] hda - fix DisplayPort naming Wu Fengguang
2008-11-22  1:40 ` [PATCH 7/7] hda - fix build warning when CONFIG_PROC_FS=n Wu Fengguang
2008-11-22 10:19 ` [PATCH 0/7] minor HDMI cleanups and fixes Takashi Iwai
2008-11-22 10:22   ` Wu Fengguang
2008-11-22 13:12   ` Serato patch review LCID Fire
2008-11-24  6:24     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081122014308.926922791@linux.intel.com \
    --to=wfg@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox