From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: naveen krishna ch <naveenkrishna.ch@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH 6/7] ASoC: TWL4030: Add volume controls for outputs
Date: Fri, 5 Dec 2008 10:44:53 +0000 [thread overview]
Message-ID: <20081205104453.GA308@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <ef0d8a250812042044n3968719r6eb996897ce90ade@mail.gmail.com>
On Fri, Dec 05, 2008 at 10:14:35AM +0530, naveen krishna ch wrote:
> The min and max values are from 0 to 209 and they r repeating for every 4
> steps
> Can any one explain this
Does this patch help?
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 3c9fdf2..afda2fc 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -223,7 +223,7 @@ static void twl4030_init_chip(struct snd_soc_codec *codec)
.put = snd_soc_put_volsw_r2_twl4030, \
.private_value = (unsigned long)&(struct soc_mixer_control) \
{.reg = reg_left, .rreg = reg_right, .shift = xshift, \
- .max = xmax, .invert = xinvert} }
+ .rshift = xshift, .max = xmax, .invert = xinvert} }
#define SOC_SINGLE_TLV_TWL4030(xname, xreg, xshift, xmax, xinvert, tlv_array) \
SOC_DOUBLE_TLV_TWL4030(xname, xreg, xshift, xshift, xmax, \
xinvert, tlv_array)
next prev parent reply other threads:[~2008-12-05 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 20:07 [PATCH 0/7] ASoC updates Mark Brown
2008-12-01 20:07 ` [PATCH 1/7] ASoC: Rename snd_soc_register_card() to snd_soc_init_card() Mark Brown
2008-12-01 20:07 ` [PATCH 2/7] ASoC: Annotate core removal function Mark Brown
2008-12-01 20:07 ` [PATCH 3/7] ASoC: Remove in-code changelog from AD73311 driver Mark Brown
2008-12-01 20:07 ` [PATCH 4/7] ASoC: TWL4030: Change the capture volume control to TLV Mark Brown
2008-12-01 20:07 ` [PATCH 5/7] ASoC: TWL4030: Change the common playback volume controls Mark Brown
2008-12-01 20:07 ` [PATCH 6/7] ASoC: TWL4030: Add volume controls for outputs Mark Brown
2008-12-01 20:07 ` [PATCH 7/7] ASoC: Don't free static data in WM9713 Mark Brown
2008-12-05 4:44 ` [PATCH 6/7] ASoC: TWL4030: Add volume controls for outputs naveen krishna ch
2008-12-05 10:44 ` Mark Brown [this message]
2008-12-05 11:17 ` naveen krishna ch
2008-12-08 7:13 ` Peter Ujfalusi
2008-12-01 20:31 ` [PATCH 0/7] ASoC updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205104453.GA308@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox