From: Daniel Mack <daniel@caiaq.org>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, u.luckas@road.de
Subject: Re: [PATCH] tlv320aic3x: control additions and cleanups
Date: Fri, 5 Dec 2008 14:46:02 +0100 [thread overview]
Message-ID: <20081205134602.GA1821@buzzloop.caiaq.de> (raw)
In-Reply-To: <20081205134257.GD10489@sirena.org.uk>
On Fri, Dec 05, 2008 at 01:42:58PM +0000, Mark Brown wrote:
> > > On Fri, Dec 05, 2008 at 02:45:04PM +0200, Jarkko Nikula wrote:
> > and now
>
> > PGAL -> HPL
> > PGAL -> HPR
>
> > PGAR seems to be missing?
>
> Hrm. This looks like it just substitutes two single controls for one
> stereo control, which seems reasonable and shouldn't loose any control:
>
> > - SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > - PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
> > + SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > + 0, 0x7f, 1),
> > + SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
> > + 0, 0x7f, 1),
>
> Possibly the controls are mislabeled?
We could call them "HPR PGA left Bypass Playback Volume" and "HPR PGA
right Bypass Playback Volume" to be more precise.
Daniel
next prev parent reply other threads:[~2008-12-05 13:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 17:51 [PATCH] tlv320aic3x: control additions and cleanups Daniel Mack
2008-12-04 18:32 ` Jarkko Nikula
2008-12-04 18:43 ` Mark Brown
2008-12-04 18:37 ` Mark Brown
2008-12-04 18:47 ` Daniel Mack
2008-12-04 18:53 ` Mark Brown
2008-12-05 13:02 ` Jarkko Nikula
2008-12-05 13:12 ` Mark Brown
2008-12-05 13:37 ` Jarkko Nikula
2008-12-05 12:45 ` Jarkko Nikula
2008-12-05 13:00 ` Mark Brown
2008-12-05 13:21 ` Jarkko Nikula
2008-12-05 13:42 ` Mark Brown
2008-12-05 13:46 ` Daniel Mack [this message]
2008-12-05 15:11 ` Daniel Mack
2008-12-05 15:37 ` Jarkko Nikula
2008-12-05 16:24 ` Mark Brown
2008-12-05 16:31 ` [PATCH] [RESEND] " Daniel Mack
2008-12-04 19:40 ` [PATCH] tlv320aic3x.c: split and add some mixer controls Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205134602.GA1821@buzzloop.caiaq.de \
--to=daniel@caiaq.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=u.luckas@road.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox