From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback) Date: Mon, 8 Dec 2008 11:31:39 +0000 Message-ID: <20081208113138.GF5159@sirena.org.uk> References: <1228723748-22911-1-git-send-email-peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id EEFD6103824 for ; Mon, 8 Dec 2008 12:31:39 +0100 (CET) Content-Disposition: inline In-Reply-To: <1228723748-22911-1-git-send-email-peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: sakoman@gmail.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, Dec 08, 2008 at 10:09:00AM +0200, Peter Ujfalusi wrote: > Peter Ujfalusi (8): > ASoC: TWL4030: Correct DAPM_DAC with power control > ASoC: TWL4030: Add Analog PGA control switch to DAPM > ASoC: TWL4030: Add DAPM event handler for output MUX selection > ASoC: TWL4030: DAPM mapping of the Earpiece output > ASoC: TWL4030: DAPM mapping of the PreDriv outputs > ASoC: TWL4030: DAPM mapping of the Headset outputs > ASoC: TWL4030: DAPM mapping of the Carkit outputs > ASoC: TWL4030: DAPM mapping of the Handsfree outputs This series looks basically good - I've commented on a few issues in the individual patches and I'd also note that you seem to be using "controls" to refer to the single control for muxes in most of the patches, which is a little confusing.