Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Thomas Schneider <nailstudio@gmx.net>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: [PATCH] hda - fix name for ALC1200
Date: Fri, 26 Dec 2008 12:20:43 +0800	[thread overview]
Message-ID: <20081226042043.GA14192@localhost> (raw)
In-Reply-To: <49538716.4040401@gmx.net>

On Thu, Dec 25, 2008 at 03:13:58PM +0200, Thomas Schneider wrote:
> Hi,
> 
> here is the output from alsa-info.sh
> 
> http://www.alsa-project.org/db/?f=8282910dc807e1f141896886cd5f8fd574117000
> 
> I found another small mistake. In the Mixer my Soundcard is shown as "Realtek ALC888".
> When i switch this to lines in patch_realtek.c then it is shown as "Realtek ALC1200".
> 
> 
> static struct hda_codec_preset snd_hda_preset_realtek[] = {
> ......
> 
>     { .id = 0x10ec0888, .name = "ALC888", .patch = patch_alc883 },
>     { .id = 0x10ec0888, .rev = 0x100101, .name = "ALC1200",
>       .patch = patch_alc883 },
> 
> .....

Good catch!

Reversing the order should fix the name.

Thanks,
Fengguang
---
hda - fix name for ALC1200

Move the more specific preset for ALC1200 above the general one for
ALC888, so that it will have the chance to get matched and selected.

Reported-by: Thomas Schneider <nailstudio@gmx.net>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 sound/pci/hda/patch_realtek.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- sound-2.6.orig/sound/pci/hda/patch_realtek.c
+++ sound-2.6/sound/pci/hda/patch_realtek.c
@@ -16638,9 +16638,9 @@ static struct hda_codec_preset snd_hda_p
 	  .patch = patch_alc882 }, /* should be patch_alc883() in future */
 	{ .id = 0x10ec0885, .name = "ALC885", .patch = patch_alc882 },
 	{ .id = 0x10ec0887, .name = "ALC887", .patch = patch_alc883 },
-	{ .id = 0x10ec0888, .name = "ALC888", .patch = patch_alc883 },
 	{ .id = 0x10ec0888, .rev = 0x100101, .name = "ALC1200",
 	  .patch = patch_alc883 },
+	{ .id = 0x10ec0888, .name = "ALC888", .patch = patch_alc883 },
 	{ .id = 0x10ec0889, .name = "ALC889", .patch = patch_alc883 },
 	{} /* terminator */
 };

  parent reply	other threads:[~2008-12-26  4:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-23 11:22 S/PDIF-Out on Asus M3A-H/HDMI with ALC1200 Thomas Schneider
2008-12-25  4:31 ` Wu Fengguang
     [not found]   ` <49538716.4040401@gmx.net>
2008-12-26  4:20     ` Wu Fengguang [this message]
2009-01-01  9:37       ` [PATCH] hda - fix name for ALC1200 Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081226042043.GA14192@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=nailstudio@gmx.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox