[PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Peter Robinson]

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..a2b62dc5 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -10,6 +11,7 @@ config SND_SUN4I_CODEC
 
 config SND_SUN4I_I2S
 	tristate "Allwinner A10 I2S Support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
@@ -19,7 +21,7 @@ config SND_SUN4I_I2S
 
 config SND_SUN4I_SPDIF
 	tristate "Allwinner A10 SPDIF Support"
-	depends on OF
+	depends on OF && (ARCH_SUNXI || COMPILE_TEST)
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help
-- 
2.9.3

Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

Hi,

On Mon, Aug 22, 2016 at 01:12:42PM +0100, Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Arnd Bergmann]

On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
> these if the appropriate SoC they're embedded in isn't enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  sound/soc/sunxi/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd..a2b62dc5 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>  
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>         select SND_SOC_GENERIC_DMAENGINE_PCM
>         select REGMAP_MMIO
> 

Makes sense, though I think it's nicer to add the dependency to the entire
menu, so we hide that as well, and don't have to add the line to future
entries:

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd01fd8..dd2368297fd3 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"

Either way
Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

On Mon, Aug 22, 2016 at 04:49:11PM +0200, Arnd Bergmann wrote:

> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Yes, that seems better.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Peter Robinson]

On Mon, Aug 22, 2016 at 3:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
>> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
>> these if the appropriate SoC they're embedded in isn't enabled.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>>  sound/soc/sunxi/Kconfig | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
>> index 2a954bd..a2b62dc5 100644
>> --- a/sound/soc/sunxi/Kconfig
>> +++ b/sound/soc/sunxi/Kconfig
>> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>>
>>  config SND_SUN4I_CODEC
>>         tristate "Allwinner A10 Codec Support"
>> +       depends on ARCH_SUNXI || COMPILE_TEST
>>         select SND_SOC_GENERIC_DMAENGINE_PCM
>>         select REGMAP_MMIO
>>
>
> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Makes sense, will do a v2 shortly.

P

> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd01fd8..dd2368297fd3 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -1,4 +1,5 @@
>  menu "Allwinner SoC Audio support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
>
> Either way
> Acked-by: Arnd Bergmann <arnd@arndb.de>

[PATCH] ASoC: sunxi: depend on ARCH_SUNXI

[Peter Robinson]

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 sound/soc/sunxi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd..dd23682 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
-- 
2.9.3

Applied "ASoC: sunxi: depend on ARCH_SUNXI" to the asoc tree

[Mark Brown]

The patch

   ASoC: sunxi: depend on ARCH_SUNXI

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 702650bda073cb9df90e3a091ee515f340133b05 Mon Sep 17 00:00:00 2001
From: Peter Robinson <pbrobinson@gmail.com>
Date: Tue, 23 Aug 2016 18:17:46 +0100
Subject: [PATCH] ASoC: sunxi: depend on ARCH_SUNXI

Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
these if the appropriate SoC they're embedded in isn't enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sunxi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
index 2a954bd01fd8..dd2368297fd3 100644
--- a/sound/soc/sunxi/Kconfig
+++ b/sound/soc/sunxi/Kconfig
@@ -1,4 +1,5 @@
 menu "Allwinner SoC Audio support"
+	depends on ARCH_SUNXI || COMPILE_TEST
 
 config SND_SUN4I_CODEC
 	tristate "Allwinner A10 Codec Support"
-- 
2.8.1