From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: Can DMA address, periods, buffer size, etc change after hw_params is called? Date: Thu, 29 Jan 2009 10:35:54 +0100 Message-ID: <20090129103554.4a02cb04@hcegtvedt> References: <20090129081825.241be9e4@hcegtvedt> <498164BC.6080907@ladisch.de> <20090129094332.2728c908@hcegtvedt> <49816FA2.3030108@ladisch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from relay.atmel.no (relay.atmel.no [80.232.32.139]) by alsa0.perex.cz (Postfix) with ESMTP id 0D791103869 for ; Thu, 29 Jan 2009 10:35:54 +0100 (CET) In-Reply-To: <49816FA2.3030108@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 29 Jan 2009 09:58:10 +0100 Clemens Ladisch wrote: > Hans-Christian Egtvedt wrote: > > Is there a chance that the following might happen: > > - stop trigger, > > - hw_free > > - hw_params > > - prepare > > - start trigger > > > > I.e. without calling close and open? > > Yes. > > It is also possible that the same happens without hw_free, i.e., > hw_params has to initialize _or_ to change the parameters. > Okay, so to be sure I setup and release my cyclic DMA buffer safely I could use the following model: in prepare callback setup the DMA buffer, once when called. The hardware parameters should not change at this point. If I get a hw_params callback after a prepare, then release the DMA buffer, and set it up again in the prepare callback? Final cleanup of the DMA buffer can/should be done in hw_free? This sounds safe given my understanding of ALSA. Is there a flow chart which shows how the different callbacks can be called? > > Clemens Ladisch wrote: > > > The DMA address is selected by the driver in the hw_params > > > callback, but most drivers let the framework handle this by > > > calling snd_pcm_lib_malloc_pages(). > > > > Yes, this is what I do today. I am considering if I should release > > the DMA stuff in hw_free and then in the prepare callback check if > > it needs to be prepared again (since it was released in hw_free). > > The framework guarantees that prepare is called only when the hardware > parameters are set. > Noted. -- Best regards, Hans-Christian Egtvedt