From: Mark Brown <broonie@sirena.org.uk>
To: pHilipp Zabel <philipp.zabel@gmail.com>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] ASoC: pxa-ssp: PXA2xx/3xx SSP ports start from 1, not 0
Date: Tue, 3 Feb 2009 18:56:08 +0000 [thread overview]
Message-ID: <20090203185607.GL23827@sirena.org.uk> (raw)
In-Reply-To: <74d0deb30902031049g500814baje09f163a9e79805b@mail.gmail.com>
On Tue, Feb 03, 2009 at 07:49:43PM +0100, pHilipp Zabel wrote:
> Hm, hm.. Ripping ssp_init/exit's innards out of them (minus the
> ssp/irq_request parts), like this, seems to work:
Yes, that looks good. IIRC that was the direction the SSP API was
supposed to be heading in anyway. Please submit properly (with
changelog and so on) - I'll test tomorrow with PXA3xx but I'd be
surprised if there were any issues.
next prev parent reply other threads:[~2009-02-03 18:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 16:19 ASoC: UDA1380/I2S/SSP patches Philipp Zabel
2009-02-03 16:19 ` [PATCH 1/4] ASoC: uda1380: split set_dai_fmt into _both, _playback and _capture variants Philipp Zabel
2009-02-03 16:41 ` Mark Brown
2009-02-03 16:45 ` pHilipp Zabel
2009-02-04 7:19 ` Vasily Khoruzhick
2009-02-04 13:19 ` Mark Brown
2009-02-03 16:19 ` [PATCH 2/4] ASoC: pxa-ssp: PXA2xx/3xx SSP ports start from 1, not 0 Philipp Zabel
2009-02-03 16:47 ` Mark Brown
2009-02-03 17:13 ` pHilipp Zabel
2009-02-03 17:35 ` Mark Brown
2009-02-03 18:49 ` pHilipp Zabel
2009-02-03 18:56 ` Mark Brown [this message]
2009-02-03 16:19 ` [PATCH 3/4] ASoC: pxa2xx-i2s: remove GPIO pin setup Philipp Zabel
2009-02-03 16:32 ` Mark Brown
2009-02-03 16:56 ` pHilipp Zabel
2009-02-03 17:09 ` Mark Brown
2009-02-03 16:19 ` [PATCH 4/4] ASoC: pxa-ssp: select PXA_SSP Philipp Zabel
2009-02-03 16:35 ` Mark Brown
2009-02-03 17:15 ` pHilipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203185607.GL23827@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox