From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, tim.barnette@gmail.com,
"Jean-Pierre André" <jean-pierre.andre@wanadoo.fr>
Subject: Re: [Fwd: HP DV4 1155 SE - No Sound through speakers...]
Date: Wed, 4 Feb 2009 15:49:53 -0200 [thread overview]
Message-ID: <200902041549.54154.herton@mandriva.com.br> (raw)
In-Reply-To: <4989C9E6.7070902@wanadoo.fr>
Em Quarta-feira 04 Fevereiro 2009, às 15:01:26, Jean-Pierre André escreveu:
> Hi Herton,
>
> I have identified why applying your patch broke the sound worse on my
> computer, by reverting each individual modification until the sound
> comes back. It has not brought overall improvements for me, but this
> might help you getting it right.
Hmm yes, for now just disregard my original patch, I think the default pin
configs inside it are not right/needed for HP laptops.
>
> On my computer, the main problem is an IRQ one, which I knew you did
> not address, but I still wanted to know if something would improve
> (see below)
<snip>
> Your patch contained the following, mostly deleting code which was
> replaced :
>
> - switch (spec->board_config) {
> - case STAC_HP_M4:
> - /* enable internal microphone */
> - stac92xx_set_config_reg(codec, 0x0e, 0x01813040);
> - stac92xx_auto_set_pinctl(codec, 0x0e,
> - AC_PINCTL_IN_EN | AC_PINCTL_VREF_80);
> - /* fallthru */
> - case STAC_DELL_M4_2:
> - spec->num_dmics = 0;
> - spec->num_smuxes = 0;
> - spec->num_dmuxes = 0;
> - break;
> - case STAC_DELL_M4_1:
> - case STAC_DELL_M4_3:
> - spec->num_dmics = 1;
> - spec->num_smuxes = 0;
> - spec->num_dmuxes = 0;
> - break;
> - default:
> - spec->num_dmics = STAC92HD71BXX_NUM_DMICS;
> - spec->num_smuxes = ARRAY_SIZE(stac92hd71bxx_smux_nids);
> - spec->num_dmuxes = ARRAY_SIZE(stac92hd71bxx_dmux_nids);
> - };
>
> spec->multiout.num_dacs = 1;
> spec->multiout.hp_nid = 0x11;
> spec->multiout.dac_nids = stac92hd71bxx_dac_nids;
> - if (spec->dinput_mux)
> - spec->private_dimux.num_items +=
> + spec->private_dimux.num_items +=
> spec->num_dmics -
> (ARRAY_SIZE(stac92hd71bxx_dmic_nids) - 1);
>
> The main bad thing is the following line which is indicated as
> unchanged, but which does not appear in alsa 1.0.19, so I cannot
> tell if this line is wrong by itself or if this line requires some
> other code not present in alsa 1.0.19. With this line present I
> get no sound at all :
>
> spec->multiout.num_dacs = 1;
>
> The second point is you have deleted and not replaced the
> following :
>
> - /* enable internal microphone */
> - stac92xx_set_config_reg(codec, 0x0e, 0x01813040);
> - stac92xx_auto_set_pinctl(codec, 0x0e,
> - AC_PINCTL_IN_EN | AC_PINCTL_VREF_80);
>
> This line is required to get a PCM control in the sound volume
> controls. It is also related to getting the following in the syslog :
>
> Line In at Ext Rear Jack as /devices/pci0000:00/0000:00:1b.0/input/input61
>
> To me, "internal microphone", "PCM control" and "Line In at Ext Rear Jack"
> are different things (and in my computer there is no rear jack !), so
> there must be something wrong in the configuration.
I don't know now if the default pin configs in my patch had something
missing/wrong, or something in current patch_sigmatel.c autoconfig code needs
this additional forced line-in to avoid hitting some case, but I thought it's
better to let away the pin configs I added. In the new patches I rebased and
posted the forced line-in is left unchanged.
>
> With these two changes to your patch, I get the same results as with
> alsa 1.0.19.
>
> This was tested on a HP dv4-1115ef, with a sound device identified as :
>
> Codec: IDT 92HD71B7X
> Codec: Generic 10de ID 3
> vendor id : 111d76b2
> subsyst id 103c30f7
> revis id 100302
>
>
> Regards
>
> Jean-Pierre
--
[]'s
Herton
next prev parent reply other threads:[~2009-02-04 17:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4983FE7A.1040201@wanadoo.fr>
2009-01-31 7:52 ` [Fwd: HP DV4 1155 SE - No Sound through speakers...] Jean-Pierre André
2009-01-31 9:20 ` Takashi Iwai
2009-02-01 22:34 ` Tim Barnette
2009-02-02 6:45 ` Takashi Iwai
2009-02-02 15:17 ` Tim Barnette
2009-02-02 15:25 ` Takashi Iwai
2009-02-02 16:26 ` Tim Barnette
2009-02-02 16:28 ` Takashi Iwai
2009-02-02 17:01 ` Tim Barnette
2009-02-02 17:10 ` Takashi Iwai
2009-02-13 19:16 ` Tim Barnette
2009-02-13 19:22 ` Tim Barnette
2009-02-14 10:24 ` Takashi Iwai
2009-02-14 19:13 ` Herton Ronaldo Krzesinski
2009-02-16 10:48 ` Takashi Iwai
2009-02-16 13:21 ` Takashi Iwai
2009-02-17 19:51 ` Tim Barnette
2009-02-18 13:16 ` Herton Ronaldo Krzesinski
2009-02-24 18:08 ` Tim Barnette
2009-02-02 18:20 ` Herton Ronaldo Krzesinski
2009-02-02 18:52 ` Takashi Iwai
2009-02-02 19:19 ` Tim Barnette
2009-02-02 19:48 ` Herton Ronaldo Krzesinski
2009-02-03 13:49 ` Jean-Pierre André
2009-02-04 17:01 ` Jean-Pierre André
2009-02-04 17:09 ` Takashi Iwai
2009-02-04 17:37 ` Jean-Pierre André
2009-02-04 17:40 ` Herton Ronaldo Krzesinski
2009-02-04 22:42 ` Takashi Iwai
2009-02-05 2:46 ` Tim Barnette
2009-02-05 7:06 ` Takashi Iwai
2009-02-05 7:04 ` Takashi Iwai
2009-02-04 17:49 ` Herton Ronaldo Krzesinski [this message]
[not found] <mailman.2709.1234557113.1965.alsa-devel@alsa-project.org>
2009-02-16 5:25 ` [Fwd: HP DV4 1155 SE - No Sound through, speakers...] Guy Stalnaker
2009-02-16 10:47 ` Takashi Iwai
2009-02-18 4:10 ` Guy Stalnaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902041549.54154.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=alsa-devel@alsa-project.org \
--cc=jean-pierre.andre@wanadoo.fr \
--cc=tim.barnette@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox