From: Michael Schwingen <rincewind@discworld.dascon.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Michael Schwingen <michael@schwingen.org>, alsa-devel@alsa-project.org
Subject: Re: PATCH: Maxdata Favorit 100XS support
Date: Thu, 5 Feb 2009 09:36:48 +0100 [thread overview]
Message-ID: <20090205083648.GA17506@a-tuin.dascon.de> (raw)
In-Reply-To: <s5htz797365.wl%tiwai@suse.de>
On Thu, Feb 05, 2009 at 08:28:50AM +0100, Takashi Iwai wrote:
> The patch looks almost good but there are a few issues to fix.
>
> First off, please use a unified diff (diff -u) for a patch.
> Then, rebase your patch to the latest sound git tree[*] or 2.6.29-rc3
> at least.
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
>
> Some stuff in patch_realtek.c in the latest tree was changed to be
> incompatible from 2.6.28. For example,
OK.
> Don't you use alc260_favorit100_init_verbs?
I intended to - probably some last-minute error when cleaning up for the
diff.
> Could you fix these and repost?
Sure. It might take some days.
cu
Michael
next prev parent reply other threads:[~2009-02-05 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 19:30 PATCH: Maxdata Favorit 100XS support Michael Schwingen
2009-02-05 7:28 ` Takashi Iwai
2009-02-05 8:36 ` Michael Schwingen [this message]
[not found] ` <20090222175845.GA30047@discworld.dascon.de>
2009-02-24 11:35 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205083648.GA17506@a-tuin.dascon.de \
--to=rincewind@discworld.dascon.de \
--cc=alsa-devel@alsa-project.org \
--cc=michael@schwingen.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox