From: Mark Brown <broonie@sirena.org.uk>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] cs4270: add support for slave mode configurations
Date: Wed, 25 Feb 2009 15:34:45 +0000 [thread overview]
Message-ID: <20090225153444.GC31637@sirena.org.uk> (raw)
In-Reply-To: <1235569041-856-1-git-send-email-daniel@caiaq.de>
On Wed, Feb 25, 2009 at 02:37:21PM +0100, Daniel Mack wrote:
> reg = snd_soc_read(codec, CS4270_MODE);
> reg &= ~(CS4270_MODE_SPEED_MASK | CS4270_MODE_DIV_MASK);
> - reg |= cs4270_mode_ratios[i].speed_mode | cs4270_mode_ratios[i].mclk;
> + reg |= cs4270_mode_ratios[i].mclk;
> +
> + if (cs4270->slave_mode)
> + reg |= CS4270_MODE_SLAVE;
> + else
> + reg |= cs4270_mode_ratios[i].speed_mode;
Shouldn't this be clearing MODE_SLAVE if it's in master mode? Since
we're doing a read/modify/write here it'd probably just be as easy to
set or clear the bit when setting the DAI format rather than storing the
data and setting it here.
next prev parent reply other threads:[~2009-02-25 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 13:37 [PATCH] cs4270: add support for slave mode configurations Daniel Mack
2009-02-25 15:34 ` Mark Brown [this message]
2009-02-25 15:45 ` Daniel Mack
2009-02-25 15:48 ` Mark Brown
2009-02-27 21:51 ` Timur Tabi
2009-02-28 12:13 ` Daniel Mack
2009-02-28 16:32 ` Timur Tabi
2009-02-28 17:47 ` Daniel Mack
2009-03-01 1:09 ` Timur Tabi
2009-02-28 12:21 ` [PATCH] fix typo and removed unneeded switch case Daniel Mack
2009-03-01 1:11 ` Timur Tabi
2009-03-02 14:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225153444.GC31637@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox