From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] ASoC: UDA1380: DATAI is slave only
Date: Tue, 3 Mar 2009 15:50:54 +0000 [thread overview]
Message-ID: <20090303155054.GA19642@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1236093054-1952-2-git-send-email-philipp.zabel@gmail.com>
On Tue, Mar 03, 2009 at 04:10:52PM +0100, Philipp Zabel wrote:
> - if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) == SND_SOC_DAIFMT_CBM_CFM)
> - iface |= R01_SIM;
> + /* DATAI is slave only, so in single-link mode, this has to be slave */
> + if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) != SND_SOC_DAIFMT_CBS_CFS)
> + return -EINVAL;
Hrm, is R01_SIM not required to be set? I've no idea what it does so
quite possibly.
next prev parent reply other threads:[~2009-03-03 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 15:10 [PATCH 1/4] ASoC: Use network mode with 2 slots for 16-bit stereo in pxa-ssp/Zylonite Philipp Zabel
2009-03-03 15:10 ` [PATCH 2/4] ASoC: UDA1380: DATAI is slave only Philipp Zabel
2009-03-03 15:50 ` Mark Brown [this message]
2009-03-03 15:56 ` pHilipp Zabel
2009-03-03 15:58 ` Mark Brown
2009-03-03 15:10 ` [PATCH 3/4] ASoC: Remove version display from the UDA1380 driver Philipp Zabel
2009-03-03 15:52 ` Mark Brown
2009-03-03 15:10 ` [PATCH 4/4] ASoC: UDA1380: change decimator/interpolator register handling Philipp Zabel
2009-03-03 15:48 ` [PATCH 1/4] ASoC: Use network mode with 2 slots for 16-bit stereo in pxa-ssp/Zylonite Mark Brown
2009-03-04 1:34 ` Daniel Mack
2009-03-04 14:29 ` Mark Brown
2009-03-04 20:45 ` pHilipp Zabel
2009-03-05 16:06 ` pHilipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303155054.GA19642@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox