Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@sirena.org.uk>
To: "Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: Add GPIO support for jack reporting interface
Date: Wed, 4 Mar 2009 14:43:14 +0000	[thread overview]
Message-ID: <20090304144313.GC433@sirena.org.uk> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705ECD6DD49@dlee07.ent.ti.com>

On Tue, Mar 03, 2009 at 03:25:04PM -0600, Lopez Cruz, Misael wrote:
> Add GPIO support to jack reporting framework in ASoC using gpiolib calls.
> The gpio support exports two new functions: snd_soc_jack_add_gpios and
> snd_soc_jack_free_gpios.

Applied, thanks.  However, I'll provide a follow on patch to...

> +undo:
> +	snd_soc_jack_free_gpios(jack, i, gpios);

change this to i + 1 - confusion due to zero based indexing.

  reply	other threads:[~2009-03-04 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 21:25 [PATCH] ASoC: Add GPIO support for jack reporting interface Lopez Cruz, Misael
2009-03-04 14:43 ` Mark Brown [this message]
2009-03-04 14:52   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2009-03-03  1:05 Lopez Cruz, Misael
2009-03-03  6:41 ` Takashi Iwai
2009-03-03 11:16   ` Mark Brown
2009-03-03 11:23     ` Takashi Iwai
2009-03-03 18:39   ` Lopez Cruz, Misael
2009-03-03 18:42     ` Mark Brown
2009-03-03 18:54       ` Lopez Cruz, Misael
2009-03-03 11:14 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090304144313.GC433@sirena.org.uk \
    --to=broonie@sirena.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=x0052729@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox