From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 3/4] pxa-ssp: don't touch ssp registers when stream is running Date: Wed, 4 Mar 2009 20:42:22 +0000 Message-ID: <20090304204222.GC10731@sirena.org.uk> References: <20090304201505.GE12183@buzzloop.caiaq.de> <1236197820-21022-1-git-send-email-daniel@caiaq.de> <1236197820-21022-2-git-send-email-daniel@caiaq.de> <1236197820-21022-3-git-send-email-daniel@caiaq.de> <20090304203350.GB10731@sirena.org.uk> <20090304203911.GA18917@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 7310810386B for ; Wed, 4 Mar 2009 21:42:29 +0100 (CET) Content-Disposition: inline In-Reply-To: <20090304203911.GA18917@buzzloop.caiaq.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, Tim Ruetz , Philipp Zabel , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Mar 04, 2009 at 09:39:11PM +0100, Daniel Mack wrote: > On Wed, Mar 04, 2009 at 08:33:52PM +0000, Mark Brown wrote: > > I'd expect an error to be reported here - if we needed to change the > > settings and can't things could go wrong. Ideally it'd check to see if > > the DAI format was being changed and only error if it was. > In my tests, pxa_ssp_set_dai_fmt() was simply called twice, once for the > input, once for the ouput. Hence I believed a silent exit in such a case That'll be because you weren't changing the DAI format - hence my comment about only erroring if the format is changed. > fine. Does 'arecord -f cd | aplay -f cd' work for you? It won't, but that's because I don't have hardware that can play back cd format audio through the SSP port :)