From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@sirena.org.uk>
Subject: Re: [PATCH 2/4] soc-dai: add bitfields for
	hardware	I2S formats
Date: Thu, 5 Mar 2009 12:03:35 +0000
Message-ID: <20090305120335.GF2416@sirena.org.uk>
References: <20090304201505.GE12183@buzzloop.caiaq.de>
	<1236197820-21022-1-git-send-email-daniel@caiaq.de>
	<1236197820-21022-2-git-send-email-daniel@caiaq.de>
	<20090304223057.GD10731@sirena.org.uk>
	<20090304231223.GB20915@buzzloop.caiaq.de>
	<20090305105357.GB2416@sirena.org.uk>
	<20090305113141.GC28878@buzzloop.caiaq.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111])
	by alsa0.perex.cz (Postfix) with ESMTP id 16EC0103891
	for <alsa-devel@alsa-project.org>; Thu,  5 Mar 2009 13:03:36 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20090305113141.GC28878@buzzloop.caiaq.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, Tim Ruetz <tim@caiaq.de>, Liam Girdwood <lrg@kernel.org>
List-Id: alsa-devel@alsa-project.org

On Thu, Mar 05, 2009 at 12:31:41PM +0100, Daniel Mack wrote:
> On Thu, Mar 05, 2009 at 10:53:57AM +0000, Mark Brown wrote:

> > The other option would be to use the TDM mode interface to set this up
> > since that's roughly what it is; my main concern here is that we already
> > have two ways of doing this and I'd like to try to keep the number down
> > for consistency.

> Probably a matter of taste, but IMO TDM mode is not the place either.
> Userspace could decide sending out 24bit samples out of a sudden (which
> the CPU DAI might accept) and in this case, you'd need some special
> logic in the board file again to set up deviders, time slots etc, right?

That's why the clocking interface is generally used here - it's more
orthogonal.

> > Yes, I'm just thinking we should be able to use the same name for this
> > with every format.

> Ok, I now call them SND_SOC_DAIFMT_FF_{UNSPEC,16BIT,24BIT,32BIT}. Are
> you fine with these names?

Yes, though I'd still prefer to use an existing interface rather than
add a new one.