From: Mark Brown <broonie@sirena.org.uk>
To: "Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver
Date: Fri, 6 Mar 2009 11:01:19 +0000 [thread overview]
Message-ID: <20090306110116.GA6493@sirena.org.uk> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705ECE137B9@dlee07.ent.ti.com>
On Thu, Mar 05, 2009 at 11:32:31AM -0600, Lopez Cruz, Misael wrote:
> Add headset jack detection for SDP3430 boards using SoC jack
> reporting interface. Headset detection on SDP3430 board is
> achieved through TWL4030 GPIO_2 pin.
Applied, thanks. One comment:
> +/* Headset jack detection gpios */
> +static struct snd_soc_jack_gpio hs_jack_gpios[] = {
> + {
> + .gpio = (OMAP_MAX_GPIO_LINES + 2),
It feels like there should be a nicer way of specifying the GPIO
number?
next prev parent reply other threads:[~2009-03-06 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 17:32 [PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver Lopez Cruz, Misael
2009-03-06 11:01 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-04 17:39 Lopez Cruz, Misael
2009-03-04 19:07 ` Mark Brown
2009-03-04 20:33 ` Lopez Cruz, Misael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306110116.GA6493@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox