Re: SoC pxa2xx-ac97 + wm9705 + touchscreen suspend/resume

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Thu, Apr 02, 2009 at 03:53:30PM +0100, Mark Brown wrote:
> On Thu, Apr 02, 2009 at 03:40:17PM +0100, Russell King - ARM Linux wrote:
> 
> > It's actually worse though - using my devmem2 hack no longer restores
> > things to a functional state.  devmem2 says the control register is
> > now set as:
> 
> Gah, I see one problem with the patch I sent.  The one below *might* do
> better if you have time to test it.  In any case, thanks a lot for your
> help here - I'm fairly confident that the remaining problems you're
> seeing are due to the lack of suspend and resume operations in the
> WM9705 driver.
> 
> >From eeec4f57eb9d8f5f45d9536319e0eb130cc3ba28 Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Date: Thu, 2 Apr 2009 15:49:41 +0100
> Subject: [PATCH] ASoC: Implement suspend and resume operations for WM9705
> 
> Compile tested only.

I beg to disagree with that statement...

sound/soc/codecs/wm9705.c: In function `wm9705_soc_suspend':
sound/soc/codecs/wm9705.c:326: error: `AC97_POWERDONW' undeclared (first use in this function)
sound/soc/codecs/wm9705.c:326: error: (Each undeclared identifier is reported only once
sound/soc/codecs/wm9705.c:326: error: for each function it appears in.)
sound/soc/codecs/wm9705.c: At top level:
sound/soc/codecs/wm9705.c:445: warning: initialization from incompatible pointer type

Fixing these results in something which can be built, and along with
your other two for the soc-core resume and the ac97 device parent,
the complaints from the touchscreen driver no longer appear.

Thanks.