From: Mark Brown <broonie@sirena.org.uk>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] General fix for Palm27x aSoC driver
Date: Sun, 12 Apr 2009 18:06:26 +0100 [thread overview]
Message-ID: <20090412170626.GD4295@sirena.org.uk> (raw)
In-Reply-To: <200904121858.42931.marek.vasut@gmail.com>
On Sun, Apr 12, 2009 at 06:58:42PM +0200, Marek Vasut wrote:
> +static struct platform_device palmld_pxa2xx_pcm = {
> + .name = "pxa2xx-pcm",
> + .id = -1,
> +};
This should follow the pattern that everything else uses with the struct
platform_device in devices.c and board files triggering registration of
that.
> +static struct platform_device palmld_pxa2xx_ac97 = {
> + .name = "pxa2xx-ac97",
> + .id = -1,
> + .dev = {
> + .platform_data = &palmld_ac97_pdata,
> + },
> +};
No, use pxa_set_ac97_info().
> +static struct platform_device palmld_wm9712_codec = {
No, the WM9712 is not a platform device.
next prev parent reply other threads:[~2009-04-12 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 16:58 [PATCH] General fix for Palm27x aSoC driver Marek Vasut
2009-04-12 17:06 ` Mark Brown [this message]
2009-04-12 17:20 ` Marek Vasut
2009-04-12 17:24 ` Marek Vasut
2009-04-12 17:30 ` Robert Jarzmik
2009-04-12 18:00 ` Mark Brown
2009-04-12 17:58 ` Mark Brown
2009-04-12 18:51 ` Marek Vasut
2009-04-14 17:51 ` Marek Vasut
2009-04-14 19:50 ` Mark Brown
2009-04-14 21:42 ` Marek Vasut
2009-04-15 2:23 ` Eric Miao
2009-04-15 5:00 ` Marek Vasut
2009-04-15 5:11 ` Eric Miao
2009-04-15 8:21 ` Mark Brown
2009-04-16 2:43 ` Eric Miao
2009-04-16 4:45 ` Marek Vasut
2009-04-17 9:42 ` Marek Vasut
2009-04-18 17:02 ` Marek Vasut
2009-04-19 13:52 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090412170626.GD4295@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox