From: Marek Vasut <marek.vasut@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Eric Miao <eric.y.miao@gmail.com>,
alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: Question about pxa2xx-ac97-lib.c
Date: Sun, 12 Apr 2009 19:02:40 +0200 [thread overview]
Message-ID: <200904121902.41007.marek.vasut@gmail.com> (raw)
In-Reply-To: <20090412170036.GB4295@sirena.org.uk>
On Sunday 12 of April 2009 19:00:37 Mark Brown wrote:
> On Sun, Apr 12, 2009 at 04:47:39PM +0200, Marek Vasut wrote:
> > One more thing, I'd like to ask how to change the reset_gpio in the above
> > file. Will I have to make copy of pxa_ac97_dai[PXA2XX_DAI_AC97_HIFI] in
> > palm27x.c and change the .probe pointer to my own function that sets the
> > proper platform data? That is, something like the following? Thanks
>
> BTW, I meant to say in reply to the previous mail - you really should
> copy all audio discussion to at least alsa-devel.
>
> > +/* Palms use GPIO95 for AC97 reset */
> > +static int palm_ac97_probe(struct platform_device *pdev,
> > + struct snd_soc_dai *dai)
> > +{
> > + struct platform_device *pd = to_platform_device(dai->dev);
> > + static struct pxa2xx_ac97_platform_data pdata = {
> > + .reset_gpio = 95,
> > + };
> > + printk("%s[%i]\n", __FUNCTION__, __LINE__);
> > + pd->dev.platform_data = &pdata;
> > + return pxa2xx_ac97_hw_probe(pd);
> > +}
>
> Look in mainline - pxa2xx-ac97-lib already provides platform data based
> configuration of the GPIO to use for reset.
Yes, I sent the new version and CCed alsa-devel.
prev parent reply other threads:[~2009-04-12 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200904121647.39464.marek.vasut@gmail.com>
2009-04-12 16:36 ` Question about pxa2xx-ac97-lib.c Robert Jarzmik
2009-04-12 16:53 ` Mark Brown
2009-04-12 16:55 ` Marek Vasut
2009-04-12 17:00 ` Mark Brown
2009-04-12 17:02 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904121902.41007.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox