From: Jarkko Nikula <jarkko.nikula@nokia.com>
To: "Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
ext@alsa-project.org, Brown <broonie@sirena.org.uk>
Subject: Re: [PATCH 1/2] ASoC: omap-mcbsp: Correct the DSP_B mode
Date: Tue, 14 Apr 2009 15:49:00 +0300 [thread overview]
Message-ID: <20090414154900.1e9dc607.jarkko.nikula@nokia.com> (raw)
In-Reply-To: <200904141532.30478.peter.ujfalusi@nokia.com>
On Tue, 14 Apr 2009 14:32:30 +0200
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com> wrote:
> Should it be like this instead:
> + temp_fmt ^= SND_SOC_DAIFMT_NB_IF;
>
Absolutely yes, good catch :-)
>
> We only need to invert the FS polarity and the bclk should stay as it is..
> Also should than this modified fmt stored to mcbsp_data->fmt later?
>
No since it's used only inside omap_mcbsp_dai_set_dai_fmt to tune polarity for the mode default. That's why there is this temp_fmt variable.
Jarkko
next prev parent reply other threads:[~2009-04-14 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 7:45 [PATCH 0/2] ASoC: DSP mode corrections for omap-mcbsp Peter Ujfalusi
2009-04-14 7:45 ` [PATCH 1/2] ASoC: omap-mcbsp: Correct the DSP_B mode Peter Ujfalusi
2009-04-14 7:45 ` [PATCH 2/2] ASoC: omap-mcbsp: Add DSP_A support Peter Ujfalusi
2009-04-14 8:20 ` [PATCH 1/2] ASoC: omap-mcbsp: Correct the DSP_B mode Jarkko Nikula
2009-04-14 8:40 ` Peter Ujfalusi
2009-04-14 9:02 ` Jarkko Nikula
2009-04-14 9:31 ` Mark Brown
2009-04-14 10:34 ` Peter Ujfalusi
2009-04-14 10:47 ` [PATCH 1/2] ASoC: omap-mcbsp: Correct the?DSP_B mode Mark Brown
2009-04-14 11:20 ` [PATCH 1/2] ASoC: omap-mcbsp: Correct the DSP_B mode Jarkko Nikula
2009-04-14 11:32 ` Arun KS
2009-04-14 12:58 ` Jarkko Nikula
2009-04-14 11:56 ` Peter Ujfalusi
2009-04-14 12:01 ` Mark Brown
2009-04-14 12:32 ` Peter Ujfalusi
2009-04-14 12:49 ` Jarkko Nikula [this message]
2009-04-14 13:00 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414154900.1e9dc607.jarkko.nikula@nokia.com \
--to=jarkko.nikula@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=ext@alsa-project.org \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox