From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Joonyoung Shim <jy0922.shim@samsung.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"bhmin@samsung.com" <bhmin@samsung.com>
Subject: Re: [PATCH v2 1/1] ASoC: TWL4030: Add VDL path support
Date: Thu, 23 Apr 2009 10:37:47 +0300 [thread overview]
Message-ID: <200904231037.47874.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <49EE996E.40504@samsung.com>
On Wednesday 22 April 2009 07:13:34 ext Joonyoung Shim wrote:
> Add DAPMs for VDL(Voice Down Link) path. To support VDL path, we have
> to change DAPMs of outputs(Earpiece, PreDrive Left/Right, Headset
> Left/Right, Carkit Left/Right) from mux to mixer.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
Yes, this has been posted some time ago, I thought you gave up on it ;)
At the moment I don't have any means to actually test this particular patch,
but after reading it through I think the comments given for the earlier series
has been addressed with this. I don't see any particular reason why this can
not be applied...
Mark commented a while ago about the AudioL1, AudioL2, AudioR1, AudioR2 naming
to be changed to HiFiL1, etc, but I don't have any problems with the current
naming, since it reflects the naming used in the TRM.
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
prev parent reply other threads:[~2009-04-23 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 4:13 [PATCH v2 1/1] ASoC: TWL4030: Add VDL path support Joonyoung Shim
2009-04-22 15:24 ` Mark Brown
2009-04-23 7:37 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904231037.47874.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhmin@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox